Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServerSetup: When mapping cluster disks, use $PSBoundParameters not Get-Variable #394

Closed
yardbirdsax opened this issue Feb 18, 2017 · 0 comments · Fixed by #404
Closed

xSQLServerSetup: When mapping cluster disks, use $PSBoundParameters not Get-Variable #394

yardbirdsax opened this issue Feb 18, 2017 · 0 comments · Fixed by #404
Labels
enhancement The issue is an enhancement request.

Comments

@yardbirdsax
Copy link
Contributor

Details of the scenario you try and problem that is occurring:
When mapping cluster drives, the resource gets a list of disk related parameters using Get-Variable. This can lead to problems if there are extra variables that match the pattern in scope. Instead, it should use the $PSBoundParameters variable.

The DSC configuration that is using the resource (as detailed as possible):
Any configuration using xSQLServerSetup for clustered installs.

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
WS 2016, SQL 2016

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
dev
@yardbirdsax yardbirdsax mentioned this issue Feb 18, 2017
Merged
5 tasks
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Feb 19, 2017
@johlju johlju mentioned this issue Feb 23, 2017
Closed
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 25, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Feb 25, 2017
@johlju
Changes to xSQLServerSetup
edc5a87 
Now it can correctly determine the right cluster when only parameter InstallSQLDataDir is assigned a path (issue dsccommunity#401).
Now the only mandatory path parameter is InstallSQLDataDir when installing Database Engine (issue dsccommunity#400).
It now can handle mandatory parameters, and are not using wildcards to find the variables containing paths (issue dsccommunity#394).
@johlju johlju mentioned this issue Feb 25, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Feb 27, 2017
@johlju
xSQLServerSetup: Fixes failover cluster bugs with shared disks (#404)
04237a5 
- Changes to xSQLServerSetup
  - Now it can correctly determine the right cluster when only parameter InstallSQLDataDir is assigned a path (issue #401).
  - Now the only mandatory path parameter is InstallSQLDataDir when installing Database Engine (issue #400).
  - It now can handle mandatory parameters, and are not using wildcards to find the variables containing paths (issue #394).
  - Changed tests to be more dynamically and to find the bug in issue #401.
  - Changed the logic of how the parameters are evaluated.
  - Added new requirement to xWaitForAvailabilityGroup
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 16, 2017
@johlju johlju removed their assignment Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServerSetup: Fixes failover cluster bugs with shared disks johlju/SqlServerDsc
2 participants
@yardbirdsax @johlju