Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServerSetup: During cluster install optional arguments for setup.exe are required by the resource #400

Closed
johlju opened this issue Feb 22, 2017 · 0 comments · Fixed by #404
Closed

xSQLServerSetup: During cluster install optional arguments for setup.exe are required by the resource #400

johlju opened this issue Feb 22, 2017 · 0 comments · Fixed by #404
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Feb 22, 2017

Details of the scenario you try and problem that is occurring:
When doing cluster installs, the setup.exe optional arguments are required, for example SQLUserDBDir and SQLUserDBLogDir.

This is because this code line does not support the path in InstallSQLDataDir which is used to build the paths for the optional path argument values if they are not set.

The DSC configuration that is using the resource (as detailed as possible):
Not available

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Feb 22, 2017
@johlju johlju mentioned this issue Feb 23, 2017
Closed
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Feb 25, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Feb 25, 2017
@johlju
Changes to xSQLServerSetup
edc5a87 
Now it can correctly determine the right cluster when only parameter InstallSQLDataDir is assigned a path (issue dsccommunity#401).
Now the only mandatory path parameter is InstallSQLDataDir when installing Database Engine (issue dsccommunity#400).
It now can handle mandatory parameters, and are not using wildcards to find the variables containing paths (issue dsccommunity#394).
@johlju johlju mentioned this issue Feb 25, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Feb 27, 2017
@johlju
xSQLServerSetup: Fixes failover cluster bugs with shared disks (#404)
04237a5 
- Changes to xSQLServerSetup
  - Now it can correctly determine the right cluster when only parameter InstallSQLDataDir is assigned a path (issue #401).
  - Now the only mandatory path parameter is InstallSQLDataDir when installing Database Engine (issue #400).
  - It now can handle mandatory parameters, and are not using wildcards to find the variables containing paths (issue #394).
  - Changed tests to be more dynamically and to find the bug in issue #401.
  - Changed the logic of how the parameters are evaluated.
  - Added new requirement to xWaitForAvailabilityGroup
@johlju johlju removed their assignment Apr 16, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServerSetup: Fixes failover cluster bugs with shared disks johlju/SqlServerDsc
1 participant
@johlju