Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Updated the PULL_REQUEST_TEMPLATE with an improved task list #1062

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 11, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #973

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 11, 2018
@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #1062 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1062   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

- Updated the PULL_REQUEST_TEMPLATE with an improved task list and
  modified some text to be clearer (issue dsccommunity#973).
@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 6 at r1 (raw file):

- Changes to SqlServerDsc
  - Updated the PULL_REQUEST_TEMPLATE with an improved task list and modified

Eascape the underscores here, so they do not generate italic markdown.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 6 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Eascape the underscores here, so they do not generate italic markdown.

Done.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Mar 12, 2018

:LGTM:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 11b94c8 into dsccommunity:dev Mar 12, 2018
@johlju johlju deleted the fix-issue-973 branch March 12, 2018 16:45
@johlju johlju removed the needs review The pull request needs a code review. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PULL_REQUEST_TEMPLATE: Update with new task list items
2 participants