Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL_REQUEST_TEMPLATE: Update with new task list items #973

Closed
9 tasks
johlju opened this issue Dec 29, 2017 · 0 comments · Fixed by #1062
Closed
9 tasks

PULL_REQUEST_TEMPLATE: Update with new task list items #973

johlju opened this issue Dec 29, 2017 · 0 comments · Fixed by #1062
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 29, 2017 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
I suggest we update the task list with a few items and clarify already existing. This list is updated to reflect review comments I often have to do (here and in xFailOverCluster), so I'm hoping this helps contributors from getting one less review comment from reviewers. 😄

I suggest we update with this new task list in PULL_REQUEST_TEMPLATE.md. Not all of these should be checked for each PR, and it already says in a comment in the PULL_REQUEST_TEMPLATE.md; 'Change to [x] for each task in the task list that applies to this PR'.

  • Added an entry under the Unreleased section in CHANGELOG.md?
  • Resource documentation added/updated in README.md?
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help?
  • Comment-based help added/updated?
  • Localization strings added/updated?
  • Examples appropriately added/updated?
  • Unit tests added/updated? See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where applicable)? See DSC Resource Testing Guidelines.
  • New/changed code adheres to Style Guidelines? See DSC Resource Style Guidelines and Best Practices.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 29, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Mar 11, 2018
@johlju
Changes to PULL_REQUEST_TEMPLATE
068375a 
- Updated the PULL_REQUEST_TEMPLATE with an improved task list and
  modified some text to be clearer (issue dsccommunity#973).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 11, 2018
@johlju johlju mentioned this issue Mar 11, 2018
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Mar 11, 2018
@johlju
Changes to PULL_REQUEST_TEMPLATE
e1051ef 
- Updated the PULL_REQUEST_TEMPLATE with an improved task list and
  modified some text to be clearer (issue dsccommunity#973).
johlju added a commit that referenced this issue Mar 12, 2018
@johlju
SqlServerDsc: Updated the PULL_REQUEST_TEMPLATE (#1062)
11b94c8 
- Changes to SqlServerDsc
  - Updated the PULL_REQUEST_TEMPLATE with an improved task list and
    modified some text to be clearer (issue #973).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Updated the PULL_REQUEST_TEMPLATE with an improved task list johlju/SqlServerDsc
1 participant
@johlju