Skip to content

Commit

Permalink
SqlServerDsc: Updated the PULL_REQUEST_TEMPLATE (#1062)
Browse files Browse the repository at this point in the history
- Changes to SqlServerDsc
  - Updated the PULL_REQUEST_TEMPLATE with an improved task list and
    modified some text to be clearer (issue #973).
  • Loading branch information
johlju authored Mar 12, 2018
1 parent 83eb572 commit 11b94c8
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 22 deletions.
67 changes: 45 additions & 22 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,53 @@
<!--
Thanks for submitting a Pull Request (PR) to this project.
Your contribution to this project is greatly appreciated!
Thanks for submitting a Pull Request (PR) to this project.
Your contribution to this project is greatly appreciated!
Please make sure you have read the contributing section
at https://github.com/PowerShell/SqlServerDsc#contributing.
Please make sure you have read the contributing section
at https://github.com/PowerShell/SqlServerDsc#contributing.
Please prefix the PR title with the resource name,
i.e. 'SqlSetup: My short description'
If this is a breaking change, then also prefix the PR title
with 'BREAKING CHANGE:',
i.e. 'BREAKING CHANGE: SqlSetup: My short description'
Please prefix the PR title with the resource name,
i.e. 'SqlSetup: My short description'.
If this is a breaking change, then also prefix the PR title
with 'BREAKING CHANGE:',
i.e. 'BREAKING CHANGE: SqlSetup: My short description'.
You may remove this and the other comments, but please keep the headers
and the task list.
-->
#### Pull Request (PR) description
<!--
Replace this comment with a description of your pull request.
-->
**Pull Request (PR) description**
<!-- Replace this with a description of your pull request -->

**This Pull Request (PR) fixes the following issues:**
<!-- Replace this with the list of issues or n/a. Use format: Fixes #123 -->
#### This Pull Request (PR) fixes the following issues
<!--
Replace this comment with the list of issues or n/a.
Use format:
Fixes #123
Fixes #124
-->

**Task list:**
#### Task list
<!--
To aid community reviewers in reviewing and merging your pull request (PR), please take
the time to run through the below checklist.
Change to [x] for each task in the task list that applies to your pull request (PR).
To aid community reviewers in reviewing and merging your pull request (PR),
please take the time to run through the below checklist.
Change to [x] for each task in the task list that applies to your pull
request (PR). For those task that don't apply to you pull request (PR),
leave those as is.
-->
- [ ] Change details added to Unreleased section of CHANGELOG.md?
- [ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
- [ ] Examples appropriately updated?
- [ ] New/changed code adheres to [Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
- [ ] [Unit and (optional) Integration tests](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md) created/updated where possible?
- [ ] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
- [ ] Resource documentation added/updated in README.md?
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
- [ ] Comment-based help added/updated?
- [ ] Localization strings added/updated in all localization files as appropriate?
- [ ] Examples appropriately added/updated?
- [ ] Unit tests added/updated?
See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [ ] Integration tests added/updated (where possible)?
See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [ ] New/changed code adheres to
[DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)
and [Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md)?
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

- Changes to SqlServerDsc
- Updated the PULL\_REQUEST\_TEMPLATE with an improved task list and modified
some text to be clearer
([issue #973](https://github.com/PowerShell/SqlServerDsc/issues/973)).
- Changes to SqlServerLogin
- Fix password test fails for nativ sql users
([issue #1048](https://github.com/PowerShell/SqlServerDsc/issues/1048)).
Expand Down

0 comments on commit 11b94c8

Please sign in to comment.