Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Public Function Test-IsNumericType #88

Merged
merged 5 commits into from
Dec 17, 2022

Conversation

hollanjs
Copy link
Contributor

@hollanjs hollanjs commented Dec 16, 2022

Pull Request (PR) description

Moved Test-IsNumericType from a private function in SqlServerDsc to a public function in DscResource.Common
Original issue logged in SqlServerDsc by @johlju Issue #1795

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #88 (191d53e) into main (05e5294) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #88   +/-   ##
==================================
  Coverage    90%   91%           
==================================
  Files        28    29    +1     
  Lines       544   548    +4     
==================================
+ Hits        495   499    +4     
  Misses       49    49           
Impacted Files Coverage Δ
source/Public/Test-IsNumericType.ps1 100% <100%> (ø)

@hollanjs hollanjs changed the title Fix issue 87 Added Public Function Test-IsNumericType Dec 16, 2022
@hollanjs
Copy link
Contributor Author

hollanjs commented Dec 17, 2022

@johlju johlju added the needs review The pull request needs a code review. label Dec 17, 2022
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hollanjs)

@johlju johlju merged commit 5e1d194 into dsccommunity:main Dec 17, 2022
@johlju johlju removed the needs review The pull request needs a code review. label Dec 17, 2022
@johlju
Copy link
Member

johlju commented Dec 17, 2022

@hollanjs thank you! 🙂

@hollanjs hollanjs deleted the fix-issue-87 branch December 17, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Test-IsNumericType from SqlServerDsc => DscResource.Common Public Functions
2 participants