-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Public Function Test-IsNumericType #88
Conversation
…est to be marked as Public instead of Private (missed on last pull)
…IsNumericType public function
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==================================
Coverage 90% 91%
==================================
Files 28 29 +1
Lines 544 548 +4
==================================
+ Hits 495 499 +4
Misses 49 49
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hollanjs)
@hollanjs thank you! 🙂 |
Pull Request (PR) description
Moved
Test-IsNumericType
from a private function in SqlServerDsc to a public function in DscResource.CommonOriginal issue logged in SqlServerDsc by @johlju Issue #1795
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)