Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test-IsNumericType from SqlServerDsc => DscResource.Common Public Functions #87

Closed
hollanjs opened this issue Dec 14, 2022 · 0 comments · Fixed by #88
Closed

Add Test-IsNumericType from SqlServerDsc => DscResource.Common Public Functions #87

hollanjs opened this issue Dec 14, 2022 · 0 comments · Fixed by #88
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@hollanjs
Copy link
Contributor

Problem description

Test-IsNumericType: Move to DscResource.Common as a public command was created in the SqlServerDsc module under Issue 1795. It was determined this function may better serve the DSC community from the DscResource.Common module.

This function is used to assert that an object is of a numeric type, returning a Boolean value of $true or $false.

Verbose logs

N/A

How to reproduce

N/A

Expected behavior

N/A

Current behavior

> Test-IsNumericType -Object ([System.UInt32] 1)
True
> 1 | Test-IsNumericType
True
>"a" | Test-IsNumericType
False

Suggested solution

Add to DscResource.Common under Public functions; Remove from SqlServerDsc after DscResource.Common changes have been merged.

Operating system the target node is running

N/A

PowerShell version and build the target node is running

N/A

Module version used

Name               Version
----               -------
DscResource.Common 0.12.0
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Dec 15, 2022
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants