Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-IsNumericType: Move to DscResource.Common as a public command #1795

Closed
johlju opened this issue Nov 24, 2022 · 2 comments · Fixed by #1823
Closed

Test-IsNumericType: Move to DscResource.Common as a public command #1795

johlju opened this issue Nov 24, 2022 · 2 comments · Fixed by #1823
Assignees
@hollanjs
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Nov 24, 2022

We should look at moving this to DscResource.Common (as a public command).
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Nov 24, 2022
@hollanjs
Copy link
Contributor

@johlju - while waiting on #1753, could you also assign this one to me? It is similar to the changes I made for Assert-ElevatedUser, so shouldn't take much time to cutover. I know you're busy, so I can get it all queued up on my end with no rush for integration.

@johlju
Copy link
Member Author

johlju commented Dec 14, 2022

@hollanjs This is assigned to you as well. Thank you!

This was referenced Dec 14, 2022
Closed
Merged
Merged
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollanjs hollanjs

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test-IsNumericType: Function moved to DscResource.Common Module hollanjs/SqlServerDsc
2 participants
@johlju @hollanjs