Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerManagementDsc: Remove resource named from module manifest in source #397

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 5, 2022

Pull Request (PR) description

  • ComputerManagementDsc
    • The resource names was removed from the property DscResourcesToExport
      in the module manifest in the source folder since the built module is
      automatically updated with this information by the pipeline. Fixes Issue #396.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from PlagueHO November 5, 2022 10:10
@johlju johlju added the needs review The pull request needs a code review. label Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #397 (3cc29ba) into main (438d2c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #397   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        17     17           
  Lines      1716   1716           
===================================
  Hits       1554   1554           
  Misses      162    162           

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johlju)


CHANGELOG.md line 17 at r1 (raw file):

- ComputerManagementDsc
  - The resource names was removed from the property `DscResourcesToExport`

Nitpick:

Suggestion:

  - The resource names were removed from the property `DscResourcesToExport`
    in the module manifest in the source folder as the built module is
    automatically updated with this information by the pipeline - Fixes [Issue #396](https://github.com/dsccommunity/ComputerManagementDsc/issues/396).

@johlju johlju requested a review from PlagueHO November 6, 2022 09:09
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)


CHANGELOG.md line 17 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Nitpick:

Done.

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@PlagueHO PlagueHO merged commit 3aea926 into dsccommunity:main Nov 7, 2022
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju deleted the fix/module-manifest branch February 26, 2023 08:08
@johlju johlju removed the needs review The pull request needs a code review. label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComputerManagementDsc: Remove resource named from module manifest in source
2 participants