-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComputerManagementDsc: Remove resource named from module manifest in source
#397
Conversation
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
===================================
Coverage 90% 90%
===================================
Files 17 17
Lines 1716 1716
===================================
Hits 1554 1554
Misses 162 162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johlju)
CHANGELOG.md
line 17 at r1 (raw file):
- ComputerManagementDsc - The resource names was removed from the property `DscResourcesToExport`
Nitpick:
Suggestion:
- The resource names were removed from the property `DscResourcesToExport`
in the module manifest in the source folder as the built module is
automatically updated with this information by the pipeline - Fixes [Issue #396](https://github.com/dsccommunity/ComputerManagementDsc/issues/396).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
CHANGELOG.md
line 17 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Nitpick:
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
DscResourcesToExport
in the module manifest in the source folder since the built module is
automatically updated with this information by the pipeline. Fixes Issue #396.
This Pull Request (PR) fixes the following issues
source
#396Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is