Skip to content

Commit

Permalink
ComputerManagementDsc: Remove resource named from module manifest in …
Browse files Browse the repository at this point in the history
…`source` (#397)

* ComputerManagementDsc: Remove resource named from module manifest in `source`

* Fix typo in CHANGELOG.md

* Fix review comment at r1

* Fix changelog
  • Loading branch information
johlju authored Nov 7, 2022
1 parent 438d2c2 commit 3aea926
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 18 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Support Options Parameter for domain join - Fixes [Issue #234](https://github.com/dsccommunity/ComputerManagementDsc/issues/234).
- When joining a computer to a domain, existing AD computer objects will be deleted - Fixes [Issue #55](https://github.com/dsccommunity/ComputerManagementDsc/issues/55), [Issue #58](https://github.com/dsccommunity/ComputerManagementDsc/issues/58).

### Changed

- ComputerManagementDsc
- The resource names were removed from the property `DscResourcesToExport`
in the module manifest in the source folder as the built module is
automatically updated with this information by the pipeline - Fixes [Issue #396](https://github.com/dsccommunity/ComputerManagementDsc/issues/396).

## [8.5.0] - 2021-09-13

### Added
Expand Down
19 changes: 1 addition & 18 deletions source/ComputerManagementDsc.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,7 @@
AliasesToExport = @()

# DSC resources to export from this module
DscResourcesToExport = @(
'Computer'
'OfflineDomainJoin'
'PendingReboot'
'PowerPlan'
'PowerShellExecutionPolicy'
'RemoteDesktopAdmin'
'ScheduledTask'
'SmbServerConfiguration'
'SmbShare'
'SystemLocale'
'TimeZone'
'VirtualMemory'
'WindowsEventLog'
'WindowsCapability'
'IEEnhancedSecurityConfiguration'
'UserAccountControl'
)
DscResourcesToExport = @()

# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
PrivateData = @{
Expand Down

0 comments on commit 3aea926

Please sign in to comment.