Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerManagementDsc: Remove resource named from module manifest in source #397

Merged
merged 4 commits into from
Nov 7, 2022
Merged

ComputerManagementDsc: Remove resource named from module manifest in source #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa3d9c2
ComputerManagementDsc: Remove resource named from module manifest in …
johlju Nov 5, 2022
1ccd11a
Fix typo in CHANGELOG.md
johlju Nov 5, 2022
14e6307
Fix review comment at r1
johlju Nov 6, 2022
3cc29ba
Fix changelog
johlju Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Support Options Parameter for domain join - Fixes [Issue #234](https://github.com/dsccommunity/ComputerManagementDsc/issues/234).
- When joining a computer to a domain, existing AD computer objects will be deleted - Fixes [Issue #55](https://github.com/dsccommunity/ComputerManagementDsc/issues/55), [Issue #58](https://github.com/dsccommunity/ComputerManagementDsc/issues/58).

### Changed

- ComputerManagementDsc
- The resource names were removed from the property `DscResourcesToExport`
in the module manifest in the source folder as the built module is
automatically updated with this information by the pipeline - Fixes [Issue #396](https://github.com/dsccommunity/ComputerManagementDsc/issues/396).

## [8.5.0] - 2021-09-13

### Added
Expand Down
19 changes: 1 addition & 18 deletions source/ComputerManagementDsc.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,7 @@
AliasesToExport = @()

# DSC resources to export from this module
DscResourcesToExport = @(
'Computer'
'OfflineDomainJoin'
'PendingReboot'
'PowerPlan'
'PowerShellExecutionPolicy'
'RemoteDesktopAdmin'
'ScheduledTask'
'SmbServerConfiguration'
'SmbShare'
'SystemLocale'
'TimeZone'
'VirtualMemory'
'WindowsEventLog'
'WindowsCapability'
'IEEnhancedSecurityConfiguration'
'UserAccountControl'
)
DscResourcesToExport = @()

# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
PrivateData = @{
Expand Down