Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryDsc: Rename module from xActiveDirectory #312

Closed
johlju opened this issue Jun 4, 2019 · 13 comments · Fixed by #447
Closed

ActiveDirectoryDsc: Rename module from xActiveDirectory #312

johlju opened this issue Jun 4, 2019 · 13 comments · Fixed by #447
Assignees
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 4, 2019

Once community feels comfortable that this module follows the style guideline and test guidelines (minus the integration tests we can't enforce yet), then let's rename this module.

See issue #172 that should be closed first before this one.

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 4, 2019
@johlju
Copy link
Member Author

johlju commented Jun 22, 2019

I gathered the issues that I think we need to resolve before we rename the module in this project board https://github.com/PowerShell/xActiveDirectory/projects/2. If you think more issues should be added, or an issue should not be a part of the board then feel free to comment. I don't think we should enforce to have the integration tests since there are no easy way of running them yet (still working on that).

We are very close to being able to rename the repo, just smaller issues.

@PlagueHO
Copy link
Member

Nice! If I get time I'll pick some up.

@johlju
Copy link
Member Author

johlju commented Jun 23, 2019

Would be great, and the reason we are so close is because @X-Guardian has put so much work closing issues! 😃

@johlju
Copy link
Member Author

johlju commented Jul 22, 2019

This one is ready to be worked on!

@ChrisLGardner
Copy link
Contributor

If I get some time tomorrow or this week then I'll look at getting this done. Shouldn't be too hard with a bit of regex.

@johlju
Copy link
Member Author

johlju commented Jul 22, 2019

The one that starts work on this, please let me know so I can assign it so others know not to start too 😄

@timhaintz
Copy link

@ChrisLGardner let me know if you won’t get a chance. I should have some time tonight (Australia East time) to get started. Thanks.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 23, 2019
@johlju
Copy link
Member Author

johlju commented Jul 25, 2019

@gaelcolas PR for this issue is ready to be merged soon (just minor tweaks), so can you please rename this repo when you have some time? Also we need the token from AppVeyor since previously when renaming a repo the AppVeyor token for status badges changes.

@gaelcolas
Copy link
Member

Alright, the Repo has been renamed, let me know if you need anything else.

@johlju
Copy link
Member Author

johlju commented Jul 27, 2019

@gaelcolas It seems that AppVeyor did not understand the rename of the repo. I think we need to readd the repo to the AppVeyor "PowerShell account". 😕 @kwirkykat not sure if @gaelcolas have permission there, is this something you can help with?

@johlju
Copy link
Member Author

johlju commented Jul 27, 2019

This is a list from the rename of SqlServerDsc, the same need to be done here. The list is from dsccommunity/SqlServerDsc#902 (comment).

  1. ✔️ Rename repository to ActiveDirectoryDsc.
  2. ✔️ Connect AppVeyor if needed.
  3. ✔️ Connect CodeCov if needed. This was not needed according to SqlServerDsc: Release to PowerShell Gallery SqlServerDsc#943 (comment).
  4. ✔️ Close and reopen this PR to kick of the tests again.
  5. ✔️ Add new AppVeyor token to status badges in README.md.
  6. ✔️ Merge the PR into dev when tests passes.
  7. ✔️Release the first version of ActiveDirectoryDsc .
  8. After release, update xActiveDirectory on PowerShell Gallery saying that it is obsolete. @kwirkykat fixed this for xSqlServer, see SqlServerDsc: Release to PowerShell Gallery SqlServerDsc#943 (comment).
  9. ✔️Update wiki with the correct documentation after release.

/cc @gaelcolas

@gaelcolas
Copy link
Member

I should have access. It's tied with the repo's permission.

@johlju
Copy link
Member Author

johlju commented Jul 27, 2019

Cool! When you have time please add the ActiveDirectoryDsc repo 😊

johlju pushed a commit that referenced this issue Jul 27, 2019
- Changes to ActiveDirectoryDsc
  - BREAKING CHANGE: Renamed the xActiveDirectory to ActiveDirectoryDsc and removed the 'x' from all resource names (issue #312).
@johlju johlju reopened this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants