-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveDirectoryDsc: Rename module from xActiveDirectory #312
Comments
I gathered the issues that I think we need to resolve before we rename the module in this project board https://github.com/PowerShell/xActiveDirectory/projects/2. If you think more issues should be added, or an issue should not be a part of the board then feel free to comment. I don't think we should enforce to have the integration tests since there are no easy way of running them yet (still working on that). We are very close to being able to rename the repo, just smaller issues. |
Nice! If I get time I'll pick some up. |
Would be great, and the reason we are so close is because @X-Guardian has put so much work closing issues! 😃 |
This one is ready to be worked on! |
If I get some time tomorrow or this week then I'll look at getting this done. Shouldn't be too hard with a bit of regex. |
The one that starts work on this, please let me know so I can assign it so others know not to start too 😄 |
@ChrisLGardner let me know if you won’t get a chance. I should have some time tonight (Australia East time) to get started. Thanks. |
@gaelcolas PR for this issue is ready to be merged soon (just minor tweaks), so can you please rename this repo when you have some time? Also we need the token from AppVeyor since previously when renaming a repo the AppVeyor token for status badges changes. |
Alright, the Repo has been renamed, let me know if you need anything else. |
@gaelcolas It seems that AppVeyor did not understand the rename of the repo. I think we need to readd the repo to the AppVeyor "PowerShell account". 😕 @kwirkykat not sure if @gaelcolas have permission there, is this something you can help with? |
This is a list from the rename of SqlServerDsc, the same need to be done here. The list is from dsccommunity/SqlServerDsc#902 (comment).
/cc @gaelcolas |
I should have access. It's tied with the repo's permission. |
Cool! When you have time please add the ActiveDirectoryDsc repo 😊 |
- Changes to ActiveDirectoryDsc - BREAKING CHANGE: Renamed the xActiveDirectory to ActiveDirectoryDsc and removed the 'x' from all resource names (issue #312).
Once community feels comfortable that this module follows the style guideline and test guidelines (minus the integration tests we can't enforce yet), then let's rename this module.
See issue #172 that should be closed first before this one.
The text was updated successfully, but these errors were encountered: