Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Convert the module to HQRM standards #172

Closed
johlju opened this issue Dec 11, 2017 · 2 comments
Closed

ActiveDirectoryDsc: Convert the module to HQRM standards #172

johlju opened this issue Dec 11, 2017 · 2 comments
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 11, 2017

I suggest that we updated this module to bring it inline with current HQRM standards.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 8, 2018
@johlju johlju mentioned this issue Jun 4, 2019
Closed
@johlju
Copy link
Member Author

johlju commented Jun 4, 2019

We should at least clean up the resources against the style guideline. Removing any ; that closes rows, add comment-based help to functions, replace any " with ' where applicable, etc.

See style guideline https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md

@johlju johlju mentioned this issue Jun 7, 2019
Merged
9 tasks
@johlju johlju changed the title xActiveDirectory: Convert the module to HQRM standards ActiveDirectoryDsc: Convert the module to HQRM standards Jul 28, 2019
@johlju
Copy link
Member Author

johlju commented Jul 28, 2019

Closing this issue as this is done to a high extent.

@johlju johlju closed this as completed Jul 28, 2019
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju