Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Release to PowerShell Gallery #943

Closed
3 tasks done
johlju opened this issue Dec 7, 2017 · 11 comments
Closed
3 tasks done

SqlServerDsc: Release to PowerShell Gallery #943

johlju opened this issue Dec 7, 2017 · 11 comments

Comments

@johlju
Copy link
Member

johlju commented Dec 7, 2017

We should release SqlServerDsc to PowerShell Gallery.

These are the steps to do in order listed.

  • High priority issues should be resolved and merged.
  • Release the first version of SqlServerDsc to PowerShell Gallery.
  • Update xSQLServer on PowerShell Gallery saying that it is deprecated and point to SqlServerDsc.
@johlju johlju added the on hold The issue or pull request has been put on hold by a maintainer. label Dec 7, 2017
@mohamednazar
Copy link

@johlju,

still we can use xSQLServer ?

Regards,
Mohamed Nazar

@johlju
Copy link
Member Author

johlju commented Dec 8, 2017

@mohamednazar Yes, it will not be removed from PS Gallery, but there will be no more updates for that module any longer. Going forward, all changes will be in the SqlServerDsc resource module in PS Gallery.

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed on hold The issue or pull request has been put on hold by a maintainer. breaking change When used on an issue, the issue has been determined to be a breaking change. help wanted The issue is up for grabs for anyone in the community. labels Dec 9, 2017
@johlju
Copy link
Member Author

johlju commented Dec 9, 2017

@kwirkykat when you have time, can I get your help with releasing SqlServerDsc to PowerShell Gallery? This is so we can get a new version out there that can compile configurations in Azure Automation. This would be an out-of-band release just to fix that problem.

See the issue description for the steps I see needs to be done. I need help with step 2 and 3. Let me know if I can help in any way.

/cc @mgreenegit

@johlju
Copy link
Member Author

johlju commented Dec 21, 2017

@kwirkykat Can you let me know when you have released the minor release to xSQLServer, deprecating it. Or just close this issue when you are done.

@johlju
Copy link
Member Author

johlju commented Dec 27, 2017

@kwirkykat I think that CodeCov doesn't work - probably since we rename the module. PR #969 doesn't get a CodeCov comment, and looking at an older PR which I just pushed commits to doesn't change it's comment. Looking at the Diff at CodeCov for that PR says it doesn't track files.
Can you look at it please? 😄

@kwirkykat
Copy link
Contributor

@johlju Is this still a problem? I see CodeCov on the more recent PRs. Is it incorrect? Or it just didn't update on older PRs?

@johlju
Copy link
Member Author

johlju commented Jan 20, 2018

@kwirkykat Yes it started behaving again a while back, I thought you fixed something. 😄 Maybe there was a problem with CodeCov before. I keep an eye out a let you know if i behaves strangely again.

On an other note, have you been able to add a note to xSQLServer so we can close this issue? If not, can I do something to help you?

@kwirkykat
Copy link
Contributor

@johlju Note has been added to xSQLServer and updated the project site to point to SqlServerDsc https://www.powershellgallery.com/packages/xSQLServer/9.1.0.0

@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 27, 2018
@johlju
Copy link
Member Author

johlju commented Jan 27, 2018

@kwirkykat Thank you, the change is looking good! 😄 Closing this issue.

@johlju johlju closed this as completed Jan 27, 2018
@mohamednazar
Copy link

Hi

Is it still safe to use xSQLServer DSCResource?

Regards,
Mohamed Nazar

@johlju
Copy link
Member Author

johlju commented Jan 29, 2018

@mohamednazar You can use it if it works for your scenario, but there will be no bug fixes or enhancements to xSQLServer. All bug fixes and enhancements will only be released under SqlServerDsc. SqlServerDsc will quickly move further away from xSQLServer.
Going forward any bug reports with xSQLServer must be able to be reproduced with SqlServerDsc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants