Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Module Name to ActiveDirectoryCSDsc #38

Closed
PlagueHO opened this issue Dec 8, 2017 · 3 comments
Closed

Convert Module Name to ActiveDirectoryCSDsc #38

PlagueHO opened this issue Dec 8, 2017 · 3 comments
Assignees
@PlagueHO
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Milestone
ActiveDirectoryCSDsc

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md
@PlagueHO PlagueHO added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 8, 2017
@PlagueHO PlagueHO added this to the AdcsDeploymentDsc milestone Dec 8, 2017
@PlagueHO PlagueHO mentioned this issue Dec 23, 2017
Merged
5 tasks
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Dec 23, 2017
@johlju
Copy link
Member

johlju commented Dec 27, 2017

@PlagueHO FYI. I seem to have a problem with CodeCov after rename (I think), see comment dsccommunity/SqlServerDsc#943 (comment).

@PlagueHO
Copy link
Member Author

Thanks for the heads up @johlju . Thinking about it, I'm not surprised codecov isn't aware of the rename. I'll take a look at some of my other projects that have cc support and see if I can manually rename them.

@johlju
Copy link
Member

johlju commented Dec 27, 2017

Maybe it probably lost the connection since the project doesn’t exist anymore, and a new project must created again against the “new” repo.

@PlagueHO PlagueHO changed the title Convert Module Name to AdcsDeploymentDsc Convert Module Name to ActiveDirectoryCSDsc Feb 2, 2018
@PlagueHO PlagueHO mentioned this issue Feb 2, 2018
Closed
5 tasks
@kwirkykat kwirkykat self-assigned this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
ActiveDirectoryCSDsc
Development

No branches or pull requests
3 participants
@kwirkykat @johlju @PlagueHO