-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ms auth #216
Merged
Merged
Feature/ms auth #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for Microsoft Authentication via the settings menu. There are a few known issues and TODOs which should not be hard to fix. Once the auth flow from the settings screen is complete, the auth folow for first-time login (ie no accounts added yet) must be added. Should not be very difficult. The plan is to add one more view with two login buttons. The Mojang button will just bring you to the login page. The microsoft one will launch OAuth2.
Closed
Closed
…stored (not first-time).
dscalzi
force-pushed
the
feature/ms-auth
branch
from
February 10, 2022 01:54
52dd796
to
3b2d6cf
Compare
Might be better to accept the Azure Client ID from a .gitignored file that gets included in the final build. |
I don't think that's necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Authentication
This PR is the official solution for Microsoft Authentication with Helios Launcher.
Core authorization mechanisms are implemented in helios-core.
Using helios-core in Helios Launcher.
If the launcher depends on a published version of helios-core, it will be installed like any other dependency. If the version is unpublished (as with this PR), follow this guide:
npm i
,npm run build
,npm link
(https://docs.npmjs.com/cli/v8/commands/npm-link)npm link helios-core
.Developer: Reload Window
.PR Status - Complete ✅ (Final Review + Testing Required)
Complete ✅
In Progress 🕒
None
ETA: Hoping to have this done by Sunday (Feb 13).
Note for Third-Party Launchers
Mojang accounts will no longer function as of March 10, 2022. If your launcher has not implemented Microsoft login, please integrate these changes. If your launcher has used a community implementation, you are free to continue using that. Please note that support is only provided for official solutions.
See https://www.minecraft.net/en-us/article/last-call-voluntarily-migrate-java-accounts
This code is not considered 'ready' until it is merged to
master
.Please conduct your own internal testing before shipping to your users. If you find bugs which can be reproduced in the base HeliosLauncher, please report them. Thank you.
References
Thanks