Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLS #135

Closed
wants to merge 4 commits into from
Closed

MLS #135

wants to merge 4 commits into from

Conversation

norhu1130
Copy link

@norhu1130 norhu1130 commented Jan 13, 2021

BY Kurmper

Microsoft Login Support
MLS

@norhu1130 norhu1130 changed the title MSA MLS Jan 13, 2021
Copy link

@chuhyeonjin chuhyeonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client ID needs to be changed in index.js and microsoft.js

@drdeee
Copy link

drdeee commented Jan 22, 2021

In authmanager the function validateSelected() does not work properly yet. If an account token is still valid, nothing is returned.

exports.validateSelected = async function () {
    const current = ConfigManager.getSelectedAccount()
    const isValid = await Mojang.validate(current.accessToken, ConfigManager.getClientToken())
    if (!isValid) {
        try {
            if (ConfigManager.getSelectedAccount() === 'microsoft') {
                const validate = await validateSelectedMicrosoft()
                return validate
            } else {
                const validate = await validateSelectedMojang()
                return validate
            }
        } catch (error) {
            return Promise.reject(error)
        }
--- }
+++ } else return true
}

@norhu1130
Copy link
Author

Unfortunately, I saw the bug happen,
I deleted the repo. I can't fix it.
I'm sorry.

@drdeee
Copy link

drdeee commented Jan 31, 2021

I've the code a little bit modified (better error handling, german translations & other styles) in my fork, but I can't create a pull request directly, so I'll extract the changes and remove translations to create a new pull request.

@drdeee drdeee mentioned this pull request Jan 31, 2021
@norhu1130
Copy link
Author

#143

@norhu1130 norhu1130 closed this Jan 31, 2021
This was referenced Feb 9, 2022
@dscalzi
Copy link
Owner

dscalzi commented Feb 9, 2022

For historical purposes:

Thanks everyone, official support will be coming through this PR #216

Relevant links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants