Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft login #186

Closed
wants to merge 7 commits into from
Closed

Conversation

Richienb
Copy link

I refactored code from #143.

Like in that PR, a Client ID is required for it to work.

// @dscalzi

Fixes: #143

@dscalzi dscalzi self-requested a review August 26, 2021 19:22
@dscalzi
Copy link
Owner

dscalzi commented Aug 26, 2021

Both this and 1.17 are next on the chopping block.

Copy link

@loveiu1278 loveiu1278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@zeff9801
Copy link

Is this going to be implement anytime soon?

@dscalzi
Copy link
Owner

dscalzi commented Jan 19, 2022

Unlikely

Comment on lines +151 to +156
if (!minecraftBuyed)
throw {
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.'
}
const MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support Game Pass, the purchase check will need to be skipped since it won't detect the game:

Suggested change
const minecraftBuyed = await Microsoft.checkMCStore(MCAccessToken.access_token)
if (!minecraftBuyed)
throw {
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.'
}
const MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token)
let MCProfile
try {
MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token)
} catch {
throw {
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.'
}
}

@dscalzi
Copy link
Owner

dscalzi commented Jan 19, 2022

@Richienb https://github.com/dscalzi/helios-core/blob/master/lib/microsoft/rest/MicrosoftAuth.ts

This may account for your concern, it's been a little bit since I wrote it though. It has to be tested an implemented in Helios.

This was referenced Jan 29, 2022
@coeragames
Copy link

We won't be able to use this pull request with the new commit refactoring auth in Helios Launcher.
Can you please do some edits so that this pull request won't drop support?

thanks :)

@dscalzi
Copy link
Owner

dscalzi commented Feb 7, 2022

We won't be able to use this pull request with the new commit refactoring auth in Helios Launcher. Can you please do some edits so that this pull request won't drop support?

thanks :)

@coeragames support to the master branch soon
#210 (comment)

@dscalzi dscalzi mentioned this pull request Feb 9, 2022
@dscalzi
Copy link
Owner

dscalzi commented Feb 9, 2022

Thanks everyone, official support will be coming through this PR #216

Relevant links:

@dscalzi dscalzi closed this Feb 9, 2022
This was referenced Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants