-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft login #186
Add Microsoft login #186
Conversation
Signed-off-by: Richie Bendall <[email protected]>
Both this and 1.17 are next on the chopping block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
Is this going to be implement anytime soon? |
Unlikely |
if (!minecraftBuyed) | ||
throw { | ||
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.' | ||
} | ||
const MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support Game Pass, the purchase check will need to be skipped since it won't detect the game:
const minecraftBuyed = await Microsoft.checkMCStore(MCAccessToken.access_token) | |
if (!minecraftBuyed) | |
throw { | |
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.' | |
} | |
const MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token) | |
let MCProfile | |
try { | |
MCProfile = await Microsoft.getMCProfile(MCAccessToken.access_token) | |
} catch { | |
throw { | |
message: 'You didn\'t buy Minecraft! Please use another Microsoft account or buy Minecraft.' | |
} | |
} |
@Richienb https://github.com/dscalzi/helios-core/blob/master/lib/microsoft/rest/MicrosoftAuth.ts This may account for your concern, it's been a little bit since I wrote it though. It has to be tested an implemented in Helios. |
We won't be able to use this pull request with the new commit refactoring auth in Helios Launcher. thanks :) |
@coeragames support to the master branch soon |
Thanks everyone, official support will be coming through this PR #216 Relevant links:
|
I refactored code from #143.
Like in that PR, a Client ID is required for it to work.
// @dscalzi
Fixes: #143