Fix test-selector-list.js tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinkassimo I'd consider rewriting this test as an integration test. Manually bootstrapping services and calling element callbacks is probably brittle (and harder to read). Check out test-amp-bind.js for an example of cross-component integration tests. |
|
@choumx Agreed. Will attempt a replacement test later today |
dreamofabear
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Merge to local master (#1) SmileWanted new ad code support * Merge to local master ampproject#2 * SmileWanted new ad code support 1st version of SmileWanted ad code support * fix lint errors
dreamofabear
pushed a commit
that referenced
this pull request
Jun 6, 2020
* [ADOCEAN-20673] remove livepreview1 * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly setting
sandbox,Resource, etc.On my local machine the errors are now gone.
(I am actually pretty amazed by the fact that these tests passes for quite a while and then suddenly explodes. Also sorry for the trouble created)