Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ amp-ad adocean: remove unnecessary preview ID #1 #28443

Merged
merged 3 commits into from
May 28, 2020
Merged

♻️ amp-ad adocean: remove unnecessary preview ID #1 #28443

merged 3 commits into from
May 28, 2020

Conversation

jdrobiecki
Copy link
Contributor

Remove unnecessary preview ID in accordance to changes in AdOcean adserver.

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this extension. Just some linter stuff.

ads/adocean.js Outdated
enabled: true,
emiter: data['aoEmitter'],
id: data['aoPreview'],
enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a small lint error here. You can try gulp lint --fix or if you use vscode we have some docs here to integrate the linting into the editor. Many other editors also have similar functionality.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@calebcordry
Copy link
Member

calebcordry commented May 27, 2020

Sorry, it looks like the second author is not covered by the CLA, you can add this person or try to rewrite the commit author as outlined here (you need some familiarity with git for this).

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@calebcordry
Copy link
Member

Thanks for maintaining this extension!

@calebcordry calebcordry merged commit 07ce92d into ampproject:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants