♻️ amp-ad adocean: remove unnecessary preview ID #1 (#28443)

* [ADOCEAN-20673] remove livepreview1 * fix lint error
ampproject · May 28, 2020 · 07ce92d · 07ce92d
1 parent 0e0eda7
commit 07ce92d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/ads/adocean.js b/ads/adocean.js
@@ -62,8 +62,6 @@ function setupPreview(global, data) {
   if (global.ado && data.aoPreview && !isFalseString(data.aoPreview)) {
     global.ado.preview({
       enabled: true,
-      emiter: data['aoEmitter'],
-      id: data['aoPreview'],
     });
   }
 }

diff --git a/ads/adocean.md b/ads/adocean.md
@@ -74,10 +74,10 @@ For details on the configuration semantics, see [AdOcean documentation](http://w
 ### Optional parameters
 
 - `data-ao-mode` - sync|buffered - processing mode
-- `data-ao-preview` - livepreview configuration id
+- `data-ao-preview` - true|false - whether livepreview is enabled
 - `data-ao-keys` - additional configuration, see adserver documentation, do not define different values for slaves within one master
 - `data-ao-vars` - additional configuration, see adserver documentation, do not define different values for slaves within one master
-- `data-ao-clusters` - additional configuration,see adserver documentation
+- `data-ao-clusters` - additional configuration, see adserver documentation
 - `data-ao-master` - unique id of master placement
 
 ## User Consent Integration

diff --git a/examples/ads.amp.esm.html b/examples/ads.amp.esm.html
@@ -523,7 +523,7 @@ <h2>AdOcean</h2>
           data-ao-mode="sync"
           data-ao-emitter="myao.adocean.pl"
           data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -535,7 +535,7 @@ <h2>AdOcean</h2>
           data-ao-mode="buffered"
           data-ao-emitter="myao.adocean.pl"
           data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -549,7 +549,7 @@ <h2>AdOcean master-slave</h2>
           data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7"
           data-ao-id="adoceanmyaonhqnqukjtt"
           data-ao-mode="buffered"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -562,7 +562,7 @@ <h2>AdOcean master-slave</h2>
           data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7"
           data-ao-id="adoceanmyaokiheeseoko"
           data-ao-mode="buffered"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'

diff --git a/examples/ads.amp.html b/examples/ads.amp.html
@@ -528,7 +528,7 @@ <h2>AdOcean</h2>
           data-ao-mode="sync"
           data-ao-emitter="myao.adocean.pl"
           data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -540,7 +540,7 @@ <h2>AdOcean</h2>
           data-ao-mode="buffered"
           data-ao-emitter="myao.adocean.pl"
           data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -554,7 +554,7 @@ <h2>AdOcean master-slave</h2>
           data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7"
           data-ao-id="adoceanmyaonhqnqukjtt"
           data-ao-mode="buffered"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'
@@ -567,7 +567,7 @@ <h2>AdOcean master-slave</h2>
           data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7"
           data-ao-id="adoceanmyaokiheeseoko"
           data-ao-mode="buffered"
-          data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7"
+          data-ao-preview="true"
           data-ao-keys="key1,key2,key3"
           data-ao-vars='{"a":"b","c":"d"}'
           data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'