Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need add go module unit coverage statistics in Codecov #1518

Closed
adamqqqplay opened this issue Dec 13, 2023 · 1 comment · Fixed by #1524
Closed

Need add go module unit coverage statistics in Codecov #1518

adamqqqplay opened this issue Dec 13, 2023 · 1 comment · Fixed by #1524
Assignees
@Desiki-high
Labels
enhancement New feature or request

Comments

@adamqqqplay
Copy link
Member

Currently, only rust code is included in codecov's test coverage statistics. We should also count the coverage of go modules such as nydusify, so that we can better understand the overall test coverage of the nydus project.

Steps that may be needed:

  1. Enhance makefiles such as nydusify.
  2. Add a new step in .github/workflows/smoke.yml to get go module coverage.
  3. Modify .github/codecov.yml.

Reference: #1228
@adamqqqplay adamqqqplay added the enhancement New feature or request label Dec 13, 2023
@Desiki-high Desiki-high mentioned this issue Dec 13, 2023
Closed
@Desiki-high
Copy link
Member

I will complete it later.

Desiki-high added a commit to Desiki-high/nydus that referenced this issue Dec 18, 2023
@Desiki-high
tests: add go module unit coverage to Codecov
a2f97a3 
resolve dragonflyoss#1518.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high mentioned this issue Dec 18, 2023
Merged
6 tasks
Desiki-high added a commit to Desiki-high/nydus that referenced this issue Dec 18, 2023
@Desiki-high
tests: add go module unit coverage to Codecov
335ebce 
resolve dragonflyoss#1518.

Signed-off-by: Yadong Ding <[email protected]>
Desiki-high added a commit to Desiki-high/nydus that referenced this issue Dec 18, 2023
@Desiki-high
tests: add go module unit coverage to Codecov
7bd960a 
resolve dragonflyoss#1518.

Signed-off-by: Yadong Ding <[email protected]>
Desiki-high added a commit to Desiki-high/nydus that referenced this issue Dec 18, 2023
@Desiki-high
tests: add go module unit coverage to Codecov
1300c48 
resolve dragonflyoss#1518.

Signed-off-by: Yadong Ding <[email protected]>
Desiki-high added a commit to Desiki-high/nydus that referenced this issue Dec 18, 2023
@Desiki-high
tests: add go module unit coverage to Codecov
b24a4c5 
resolve dragonflyoss#1518.

Signed-off-by: Yadong Ding <[email protected]>
imeoer pushed a commit that referenced this issue Dec 19, 2023
@Desiki-high @imeoer
tests: add go module unit coverage to Codecov
a4ec9b8 
resolve #1518.

Signed-off-by: Yadong Ding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Desiki-high Desiki-high

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add go module unit coverage statistics in Codecov Desiki-high/nydus
2 participants
@adamqqqplay @Desiki-high