Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the coverage statistics of go modules to codecov #1517

Closed
Desiki-high opened this issue Dec 13, 2023 · 3 comments
Closed

feat: add the coverage statistics of go modules to codecov #1517

Desiki-high opened this issue Dec 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Desiki-high
Copy link
Member

Additional Information

nydus/Makefile

Lines 130 to 131 in 45331d5

coverage-codecov:
TEST_WORKDIR_PREFIX=$(TEST_WORKDIR_PREFIX) ${CARGO} llvm-cov --codecov --output-path codecov.json --workspace $(EXCLUDE_PACKAGES) $(CARGO_COMMON) $(CARGO_BUILD_FLAGS) -- --skip integration --nocapture --test-threads=8

- name: Generate code coverage
run: |
CARGO_HOME=${HOME}/.cargo
CARGO_BIN=$(which cargo)
sudo -E CARGO=${CARGO_BIN} make coverage-codecov
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
files: codecov.json
fail_ci_if_error: true

image

Details about issue

Now we're only adding the coverage of the rust portion. We need to also add the coverage statistics of go modules to codecov such as https://github.com/dragonflyoss/nydus/tree/master/contrib/nydusify.

@Desiki-high Desiki-high self-assigned this Dec 13, 2023
@Desiki-high Desiki-high added the enhancement New feature or request label Dec 13, 2023
@Desiki-high
Copy link
Member Author

Desiki-high commented Dec 13, 2023

PTAL @adamqqqplay. You can put your work suggestions on this issue directly.

@Desiki-high
Copy link
Member Author

dropped in favor of #1518.

@adamqqqplay
Copy link
Member

PTAL @adamqqqplay. You can put your work suggestions on this issue directly.

Sorry, I opened a new duplicate issue, thanks for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants