Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove go test cover #1514

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

image

Details

In golang smoke test, go test don't need coverage analysis and create coverage profile.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

In golang smoke test, go test don't need coverage analysis and create coverage profile.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high requested a review from a team as a code owner December 13, 2023 05:47
@Desiki-high Desiki-high requested review from bergwolf, ccx1024cc and power-more and removed request for a team December 13, 2023 05:47
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1514 (63e1b24) into master (55a999b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   62.72%   62.73%   +0.01%     
==========================================
  Files         129      129              
  Lines       44158    44158              
  Branches    44158    44158              
==========================================
+ Hits        27697    27702       +5     
+ Misses      15092    15088       -4     
+ Partials     1369     1368       -1     

see 3 files with indirect coverage changes

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Desiki-high Does this step affect execution time?

@Desiki-high
Copy link
Member Author

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

@Desiki-high
Copy link
Member Author

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

In my local machine or Github Action, this step doesn't affect execution time. In my point, the -cover testflag doesn't make any sense.

@adamqqqplay
Copy link
Member

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

In my local machine or Github Action, this step doesn't affect execution time. In my point, the -cover testflag doesn't make any sense.

@Desiki-high Ok, I see. In addition, if you have time, can you help add the coverage statistics of nydusify and other go modules to codecov? Thanks in advance.

@Desiki-high
Copy link
Member Author

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

In my local machine or Github Action, this step doesn't affect execution time. In my point, the -cover testflag doesn't make any sense.

@Desiki-high Ok, I see. In addition, if you have time, can you help add the coverage statistics of nydusify and other go modules to codecov? Thanks in advance.

I can have a try.

@adamqqqplay
Copy link
Member

adamqqqplay commented Dec 13, 2023

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

In my local machine or Github Action, this step doesn't affect execution time. In my point, the -cover testflag doesn't make any sense.

@Desiki-high Ok, I see. In addition, if you have time, can you help add the coverage statistics of nydusify and other go modules to codecov? Thanks in advance.

I can have a try.

Thanks for your help. I will submit an new issue to track this.

@adamqqqplay adamqqqplay merged commit 194641a into dragonflyoss:master Dec 13, 2023
13 checks passed
@Desiki-high
Copy link
Member Author

Desiki-high commented Dec 13, 2023

@Desiki-high Does this step affect execution time?

I'm not sure about the execution time. I need to test it.

In my local machine or Github Action, this step doesn't affect execution time. In my point, the -cover testflag doesn't make any sense.

@Desiki-high Ok, I see. In addition, if you have time, can you help add the coverage statistics of nydusify and other go modules to codecov? Thanks in advance.

I can have a try.

Thanks for your help. I will submit an new issue to track this.

I have creatd at #1517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants