-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add go module unit coverage statistics in Codecov #1524
Merged
imeoer
merged 2 commits into
dragonflyoss:master
from
Desiki-high:makefile/coverage-codecov
Dec 19, 2023
Merged
tests: add go module unit coverage statistics in Codecov #1524
imeoer
merged 2 commits into
dragonflyoss:master
from
Desiki-high:makefile/coverage-codecov
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use contrib-tes job to test the golang modules in contrib. Signed-off-by: Yadong Ding <[email protected]>
Desiki-high
requested review from
liubin,
liubogithub,
gaius-qi,
bergwolf and
hsiangkao
and removed request for
a team
December 18, 2023 10:48
Desiki-high
changed the title
Makefile/coverage codecov
tests: add go module unit coverage statistics in Codecov
Dec 18, 2023
Desiki-high
force-pushed
the
makefile/coverage-codecov
branch
3 times, most recently
from
December 18, 2023 11:40
335ebce
to
7bd960a
Compare
This comment has been minimized.
This comment has been minimized.
Desiki-high
force-pushed
the
makefile/coverage-codecov
branch
from
December 18, 2023 12:09
7bd960a
to
1300c48
Compare
This comment has been minimized.
This comment has been minimized.
Desiki-high
changed the title
tests: add go module unit coverage statistics in Codecov
[WIP]tests: add go module unit coverage statistics in Codecov
Dec 18, 2023
resolve dragonflyoss#1518. Signed-off-by: Yadong Ding <[email protected]>
Desiki-high
force-pushed
the
makefile/coverage-codecov
branch
from
December 18, 2023 12:30
1300c48
to
b24a4c5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
- Coverage 62.72% 60.88% -1.84%
==========================================
Files 129 141 +12
Lines 44153 46277 +2124
Branches 44153 44153
==========================================
+ Hits 27695 28178 +483
- Misses 15087 16658 +1571
- Partials 1371 1441 +70 |
This comment has been minimized.
This comment has been minimized.
Desiki-high
changed the title
[WIP]tests: add go module unit coverage statistics in Codecov
tests: add go module unit coverage statistics in Codecov
Dec 18, 2023
imeoer
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Desiki-high Thank you for your great work, really helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
resolve #1518.
Details
contrib-unit-test-coverage
job to test the Golang modules in contrib.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.