-
Notifications
You must be signed in to change notification settings - Fork 773
Conversation
Thanks for your contribution. 🍻 @yunfeiyanggzq |
dde3bd5
to
8e983a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
=======================================
Coverage 46.52% 46.52%
=======================================
Files 116 116
Lines 6901 6901
=======================================
Hits 3211 3211
Misses 3433 3433
Partials 257 257
Continue to review full report at Codecov.
|
Thanks for your contribution. 🍻 @yunfeiyanggzq |
d39268c
to
21e7b31
Compare
21e7b31
to
ed45178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files in docs/cli_reference
are generated automatically. It's unnecessary to modify them manually.
get |
@@ -193,9 +193,9 @@ func initFlags() { | |||
flagSet := rootCmd.Flags() | |||
|
|||
// url & output | |||
flagSet.StringVarP(&cfg.URL, "url", "u", "", "URL of user requested downloading file(only HTTP/HTTPs supported)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emm...
IMO, URL is a proper noun and it should always be capitalized.
Ref: https://en.wikipedia.org/wiki/URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you
9bb70a8
to
c9f553e
Compare
@starnop Done |
LGTM> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c9f553e
to
425af56
Compare
Could you please rebase your code and push it again? |
Any update on this? @yunfeiyanggzq |
Sorry,I ignored the email,I will rebase it today @starnop @allencloud |
Signed-off-by: yunfeiyangbuaa <[email protected]>
425af56
to
34b2b03
Compare
done @starnop @allencloud |
* update task access time when task is downloading Signed-off-by: sunwp <[email protected]>
Signed-off-by: yunfeiyangbuaa [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #908
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
supernode:
dfget:
Ⅴ. Special notes for reviews