This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 22, 2019 09:00
1314527
to
28ce3ae
Compare
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 22, 2019 09:23
28ce3ae
to
2649c30
Compare
lowzj
reviewed
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use pkg/printer
instead of fmt
yunfeiyanggzq
force-pushed
the
dfget_output
branch
2 times, most recently
from
August 22, 2019 11:34
069b34a
to
9e7e9a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 39.64% 39.68% +0.04%
==========================================
Files 109 109
Lines 6430 6431 +1
==========================================
+ Hits 2549 2552 +3
+ Misses 3672 3671 -1
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
I have changed fmt to pkg/printer. @lowzj |
lowzj
reviewed
Aug 22, 2019
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 22, 2019 12:30
9e7e9a9
to
d7cd0ee
Compare
lowzj
reviewed
Aug 23, 2019
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 23, 2019 03:35
d7cd0ee
to
f461677
Compare
lowzj
reviewed
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- change
fmt
topkg/printer
inBackDownloader
- the example in
dfget/app/root
should be updated
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 23, 2019 06:59
f461677
to
bc92c54
Compare
Signed-off-by: yunfeiyangbuaa <[email protected]>
yunfeiyanggzq
force-pushed
the
dfget_output
branch
from
August 23, 2019 07:21
bc92c54
to
852a262
Compare
Done @lowzj |
LGTM |
Merged
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
bugfix:modify dfget output
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
bugfix:modify dfget output
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yunfeiyangbuaa [email protected]
Ⅰ. Describe what this PR did
make dfget output clear
Ⅱ. Does this pull request fix one issue?
fixes #817
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
now the out put is