Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

[bug]The dfget cli output is ugly #817

Closed
yunfeiyanggzq opened this issue Aug 15, 2019 · 11 comments · Fixed by #852
Closed

[bug]The dfget cli output is ugly #817

yunfeiyanggzq opened this issue Aug 15, 2019 · 11 comments · Fixed by #852
Labels
kind/bug This is bug report for project kind/feature status/more-info-needed This means that this issue need to input more information to address the issue clearly

Comments

@yunfeiyanggzq
Copy link
Member

yunfeiyanggzq commented Aug 15, 2019

Why you need it?

dfget version:workspace:/root/.small-dragonfly sign:15458-1565830210.799client:127.0.0.1 connected to node:127.0.3.0:8004start download by dragonflydownload SUCCESS(0) cost:2.868s length:21976647 reason:0
--2019-08-15 08:50:14--  https://dl.google.com/go/go1.12.7.src.tar.gz
dfget version:workspace:/root/.small-dragonfly sign:15571-1565830214.708client:127.0.0.1 connected to node:127.0.2.0:8003start download by dragonflydownload SUCCESS(0) cost:2.552s length:21976647 reason:0
--2019-08-15 08:50:18--  https://dl.google.com/go/go1.12.7.src.tar.gz
dfget version:workspace:/root/.small-dragonfly sign:15678-1565830218.353client:127.0.0.1 connected to node:127.0.3.0:8004start download by dragonflydownload SUCCESS(0) cost:3.679s length:21976647 reason:0
--2019-08-15 08:50:23--  https://dl.google.com/go/go1.12.7.src.tar.gz
dfget version:workspace:/root/.small-dragonfly sign:15795-1565830223.225client:127.0.0.1 connected to node:127.0.3.0:8004start download by dragonflydownload SUCCESS(0) cost:2.156s length:21976647 reason:0
--2019-08-15 08:50:26--  https://dl.google.com/go/go1.12.7.src.tar.gz
dfget version:workspace:/root/.small-dragonfly sign:15912-1565830226.292client:127.0.0.1 connected to node:127.0.3.0:8004start download by dragonflydownload SUCCESS(0) cost:1.645s length:21976647 reason:0
--2019-08-15 08:50:29--  https://dl.google.com/go/go1.12.7.src.tar.gz
dfget version:workspace:/root/.small-dragonfly sign:16025-1565830229.005client:127.0.0.1 connected to node:127.0.3.0:8004start download by dragonflydownload SUCCESS(0) cost:3.674s length:21976647 reason:0

The dfget cli is ugly,no pause ,i can't find the information i want clearly,

How it could be?

Other related information

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @yunfeiyangbuaa
While we thought ISSUE TITLE could be more specific, longer than 20 chars.
Please edit issue title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@pouchrobot pouchrobot added the status/more-info-needed This means that this issue need to input more information to address the issue clearly label Aug 15, 2019
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @yunfeiyangbuaa
While we thought ISSUE TITLE could be more specific, longer than 20 chars.
Please edit issue title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@yunfeiyanggzq yunfeiyanggzq changed the title The dfget download [feature]The dfget cli is ugly Aug 15, 2019
@inoc603
Copy link
Member

inoc603 commented Aug 15, 2019

Could you describe what information is missing and how you'd like it to be displayed, in a bit more detail?

@starnop starnop changed the title [feature]The dfget cli is ugly [feature]The dfget cli output is ugly Aug 15, 2019
@starnop
Copy link
Contributor

starnop commented Aug 15, 2019

I think it's indeed caused by missing line breaks. @yunfeiyangbuaa Would you like to perfect this?

@inoc603
Copy link
Member

inoc603 commented Aug 15, 2019

Didn't realize that "no pause" means "no new lines"... In such case, this issue may be better categorized as a bug or an enhancement, rather than a feature @starnop .

@yunfeiyanggzq
Copy link
Member Author

I think it's indeed caused by missing line breaks. @yunfeiyangbuaa Would you like to perfect this?

I will do with it

@yunfeiyanggzq
Copy link
Member Author

yunfeiyanggzq commented Aug 15, 2019

Could you describe what information is missing and how you'd like it to be displayed, in a bit more detail?

dfget version nessary?,I only care about the download information instead of that.
SUCCESS(0)In fact ,suceess(0) make me confused,it look like my work is failed
I wan't to see cid.coat time.file dir.file size,how many have been downloaded.is success? @inoc603

@yunfeiyanggzq
Copy link
Member Author

I want to see how many piece are downloading,and how many pieces is successful @starnop @inoc603

@starnop
Copy link
Contributor

starnop commented Aug 16, 2019

I want to see how many piece are downloading,and how many pieces is successful @starnop @inoc603

I don't think it's suitable to output the stdout. You can output to the log file with debug level.

@starnop
Copy link
Contributor

starnop commented Aug 16, 2019

Didn't realize that "no pause" means "no new lines"... In such case, this issue may be better categorized as a bug or an enhancement, rather than a feature @starnop .

I totally agree with you.

@starnop starnop changed the title [feature]The dfget cli output is ugly [bug]The dfget cli output is ugly Aug 16, 2019
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Aug 16, 2019
@starnop
Copy link
Contributor

starnop commented Aug 16, 2019

Could you describe what information is missing and how you'd like it to be displayed, in a bit more detail?

dfget version nessary?,I only care about the download information instead of that.
SUCCESS(0)In fact ,suceess(0) make me confused,it look like my work is failed
I wan't to see cid.coat time.file dir.file size,how many have been downloaded.is success? @inoc603

Update SUCCESS(0) to SUCCESS is OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This is bug report for project kind/feature status/more-info-needed This means that this issue need to input more information to address the issue clearly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants