Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

[feature]the supernode cli is ugly #908

Closed
yunfeiyanggzq opened this issue Sep 15, 2019 · 3 comments · Fixed by #909
Closed

[feature]the supernode cli is ugly #908

yunfeiyanggzq opened this issue Sep 15, 2019 · 3 comments · Fixed by #909
Labels
kind/bug This is bug report for project kind/feature

Comments

@yunfeiyanggzq
Copy link
Member

Ⅰ. Issue Description

### Ⅱ. Describe what happened
Usage:
  Dragonfly Supernode [flags]
  Dragonfly [command]

Available Commands:
  help        Help about any command
  version     Show the current version of supernode

Flags:
      --advertise-ip string             the supernode ip that we advertise to other peer in the p2p-network
      --config string                   the path of supernode's configuration file (default "/etc/dragonfly/supernode.yml")
  -D, --debug                           Switch daemon log level to DEBUG mode
      --down-limit int                  download limit for supernode to serve download tasks (default 5)
      --download-path string            specifies the path where to store downloaded filed from source address (default "/home/admin/supernode/repo/download")
      --download-port int               DownloadPort is the port for download files from supernode (default 8001)
      --fail-access-interval duration   failAccessInterval is the interval time after failed to access the URL (default 3m0s)
      --gc-initial-delay duration       GCInitialDelay is the delay time from the start to the first GC execution. (default 6s)
      --gc-meta-interval duration       GCMetaInterval is the interval time to execute the GC meta. (default 2m0s)
  -h, --help                            help for Dragonfly
      --home-dir string                 HomeDir is working directory of supernode (default "/home/admin/supernode")
      --max-bandwidth int               network rate that supernode can use (unit: MB/s) (default 200)
      --peer-gc-delay duration          PeerGCDelay is the delay time to execute the GC after the peer has reported the offline. (default 3m0s)
      --pool-size int                   the core pool size of ScheduledExecutorService (default 10)
      --port int                        ListenPort is the port supernode server listens on (default 8002)
      --profiler                        Set if supernode HTTP server setup profiler
      --system-bandwidth int            Network rate reserved for system (unit: MB/s) (default 20)
      --task-expire-time duration       TaskExpireTime when a task is not accessed within the taskExpireTime,and it will be treated to be expired. (default 3m0s)
      --up-limit int                    upload limit for a peer to serve download tasks (default 5)

some beginings of command descriptiones are uppercase while some not

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • dragonfly version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Sep 15, 2019
@yunfeiyanggzq
Copy link
Member Author

I will fix it

@starnop
Copy link
Contributor

starnop commented Sep 15, 2019

However, I think it's not be suitable as a bug type. WDYT?

@yunfeiyanggzq yunfeiyanggzq changed the title [bug]the supernode cli is ugly [feature]the supernode cli is ugly Sep 15, 2019
@yunfeiyanggzq
Copy link
Member Author

However, I think it's not be suitable as a bug type. WDYT?

I agree with you

sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this issue May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This is bug report for project kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants