-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenerateAssemblyInfo
target is ordered after _SetEmbeddedFilesFromSourceControlManagerUntrackedFiles
target
#572
Comments
GenerateAssemblyInfo
target is ordered after _SetEmbeddedFilesFromSourceControlManagerUntrackedFiles
target:GenerateAssemblyInfo
target is ordered after _SetEmbeddedFilesFromSourceControlManagerUntrackedFiles
target
Should be fixed by dotnet/sdk#10613. |
….AssemblyInfo.cs Workaround dotnet/sourcelink#572 by explicitly embedding the AssemblyAttributes file into the pdb.
…AssemblyInfo.cs Workaround dotnet/sourcelink#572 by explicitly embedding the AssemblyAttributes file into the pdb. Closes #7040 from eerhardt/FixSourceLinkTest Lead-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…AssemblyInfo.cs Workaround dotnet/sourcelink#572 by explicitly embedding the AssemblyAttributes file into the pdb. Closes apache#7040 from eerhardt/FixSourceLinkTest Lead-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…AssemblyInfo.cs Workaround dotnet/sourcelink#572 by explicitly embedding the AssemblyAttributes file into the pdb. Closes apache#7040 from eerhardt/FixSourceLinkTest Lead-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
* Run CI with very branch push. * Build only once, generating package in CI (with version `0.0.0-ci-$(Build.BuildNumber)` for now). This requires applying a workaround for Coverlet, to able to collect code coverage when the solution is built with `ContinuousIntegrationBuild=true` (see [this](dotnet/sourcelink#572) and [this](https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/DeterministicBuild.md). * Fix custom task conditions: `succeeded()` behavior only applies by default when `condition` is not overriden. * Add publish package guard (`Push != ''`) and options to avoid commiting new version and tag (`NoCommit`) and pushing packages to GitHub (`NoGitHubPush`) and NuGet (`NoNuGetPush`). * Bump `SourceLink` and `Coverlet` and `dotnet-version-cli` versions.
* Run CI with very branch push. * Build only once, generating package in CI (with version `0.0.0-ci-$(Build.BuildNumber)` for now). This requires applying a workaround for Coverlet, to able to collect code coverage when the solution is built with `ContinuousIntegrationBuild=true` (see [this](dotnet/sourcelink#572) and [this](https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/DeterministicBuild.md). * Fix custom task conditions: `succeeded()` behavior only applies by default when `condition` is not overriden. * Add publish package guard (`Push != ''`) and options to avoid commiting new version and tag (`NoCommit`) and pushing packages to GitHub (`NoGitHubPush`) and NuGet (`NoNuGetPush`). * Use `dotnet-version-cli` rather than custom target to update versions. * Remove custom targets and legacy, manual-publish ones. * Remove NuGet test project
Remove workaround for dotnet/sourcelink#572
Remove workaround for dotnet/sourcelink#572
…AssemblyInfo.cs Workaround dotnet/sourcelink#572 by explicitly embedding the AssemblyAttributes file into the pdb. Closes #7040 from eerhardt/FixSourceLinkTest Lead-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
* Updates generation of nuget packages with the fix available on dotnet/sourcelink#572 * #56: fixed missing exception reporting
* Update nuget package generation with fix available on dotnet/sourcelink#572 * #10: added UnparsedArgs property * #2: added management of arguments cross check * Reverted back launchSettings.json after test of #2 * Capture all exceptions until tests are managed from workflow (#2 tests)
In case nobody thought of it, you can also force ordering of other targets by making a new target that comes before/after others - thus forcing one target to be evaluated before your new target, and another one after this new one. For this workaround: <Target Name="temp" BeforeTargets="BeforeCompile" AfterTargets="GenerateAssemblyInfo"></Target> |
I was getting errors for other two files, I had to add 2 more lines to <Project>
<PropertyGroup>
<TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>
</PropertyGroup>
<ItemGroup>
<EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>
<EmbeddedFiles Include="$(GeneratedGlobalUsingsFile)"/>
<EmbeddedFiles Include="$(TargetFrameworkMonikerAssemblyAttributesPath)"/>
</ItemGroup>
</Project> |
…ory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572"
* Include Request with FromHeaderAttribute #32 * * added logic of apicontroller where the [frombody] attribute does not need to be added and fixed bug when i send a object with properties a null in the body * * Update support for method patch * Fix null reference exception when pass null properties in request model * Simplify way of parameter extract * Create a new model in Sample.Api to use it as a parameter Two new endpoints with parameters (custom or primitive object) Tests calling endpoints with a null parameter (custom or primitive object) We check if the instance is null before AddTokken in PrimitiveParameterActionTokenizer and ComplexParameterActionTokenizer We add null argument in TestServerAction instead of a null reference exception * Bump Microsoft.AspNetCore.Authentication.JwtBearer Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/aspnet/AspNetCore) from 3.0.0 to 3.1.18. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Commits](dotnet/aspnetcore@v3.0.0...v3.1.18) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update TestServerExtensionsTests.cs fix test name * Revert updated Microsoft.AspNetCore.Authentication.JwtBearer * ?. removed in last merge * * added tests * Include dependencies.props in "Solution Items" folder Update nugets and sdk version * 42 use GitHub actions instead of appveyor (#45) * Add github workflows * remove appveyor files Co-authored-by: Sergio <[email protected]> * Move "Package information" from "build/dependencies.props" to "Directory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572" Co-authored-by: Vicente Fernández Antolín <[email protected]> Co-authored-by: David Jiménez <[email protected]> Co-authored-by: Carlos Jiménez Delgado <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergio <[email protected]> Co-authored-by: David Jiménez Hernández <[email protected]>
* Include Request with FromHeaderAttribute #32 * * added logic of apicontroller where the [frombody] attribute does not need to be added and fixed bug when i send a object with properties a null in the body * * Update support for method patch * Fix null reference exception when pass null properties in request model * Simplify way of parameter extract * Create a new model in Sample.Api to use it as a parameter Two new endpoints with parameters (custom or primitive object) Tests calling endpoints with a null parameter (custom or primitive object) We check if the instance is null before AddTokken in PrimitiveParameterActionTokenizer and ComplexParameterActionTokenizer We add null argument in TestServerAction instead of a null reference exception * Bump Microsoft.AspNetCore.Authentication.JwtBearer Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/aspnet/AspNetCore) from 3.0.0 to 3.1.18. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Commits](dotnet/aspnetcore@v3.0.0...v3.1.18) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update TestServerExtensionsTests.cs fix test name * Revert updated Microsoft.AspNetCore.Authentication.JwtBearer * ?. removed in last merge * * added tests * Include dependencies.props in "Solution Items" folder Update nugets and sdk version * 42 use GitHub actions instead of appveyor (#45) * Add github workflows * remove appveyor files Co-authored-by: Sergio <[email protected]> * Move "Package information" from "build/dependencies.props" to "Directory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572" * Feature/router paramas with underscores (#51) * allow router params with _ and - * Test for allow router params with _ Co-authored-by: Alexis Martin Peña <[email protected]> * Fix TestServerAction for methods parameters (#43) * Fix TestServerAction for methods parameters * Merge With VFA91 Fork * Add Guid[] In QueryParams * Avoid add parameter when Guid[] is empty * Adding Test * using GuidArrayExtension * Remove unused method * fix for .net5 * Fixing comments * Enable any array from query params * Avoid Array with not primitives types * fix for .net 3.1 * comments fix * Change namespace & Clear function for primitives * remove dynamic * rename variables Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: Sergio <[email protected]> * Set targets and versions to Net Core 3.1, Net 5 and Net 6 Application version 3.2.0 (#54) Set targets and versions to Net Core 3.1, Net 5 and Net 6 Add Directory.Build.targets with version of nugets Modify workflows to support Net 5 and Net 6 Clean ".csproj"s * Feature/update to net6 (#55) Change PackageLicenseUrl to PackageLicenseUrl Remove SetCompatibilityVersion from the code Update README * Feature/nullable query params (#53) * Add Test For try fix a Bug * Allo Query Parameter Nullable * allow .net 3.1 build * add folder again * fix indent * fix indent * indent * indent * fix merge * Change class name and access * Pr Comments * better comment method * comment * improve performance Co-authored-by: Alexis Martin Peña <[email protected]> * Tests using WebApplicationFactory (#58) Documentation about GetStarted, WebApplicationFactory and ICollectionFixture (xunit) Refactor ValuesTests and ValuesWithHttpClientTests to test also WebApplicationFactory Co-authored-by: Sergio <[email protected]> * Allow router params in post methods (#60) Co-authored-by: Alexis Martin Peña <[email protected]> * regex_pattern include several colon (#61) Co-authored-by: Sergio <[email protected]> Co-authored-by: Vicente Fernández Antolín <[email protected]> Co-authored-by: David Jiménez <[email protected]> Co-authored-by: Carlos Jiménez Delgado <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Jiménez Hernández <[email protected]> Co-authored-by: serweck <[email protected]> Co-authored-by: Alexis Martin Peña <[email protected]>
* Include Request with FromHeaderAttribute #32 * * added logic of apicontroller where the [frombody] attribute does not need to be added and fixed bug when i send a object with properties a null in the body * * Update support for method patch * Fix null reference exception when pass null properties in request model * Simplify way of parameter extract * Create a new model in Sample.Api to use it as a parameter Two new endpoints with parameters (custom or primitive object) Tests calling endpoints with a null parameter (custom or primitive object) We check if the instance is null before AddTokken in PrimitiveParameterActionTokenizer and ComplexParameterActionTokenizer We add null argument in TestServerAction instead of a null reference exception * Bump Microsoft.AspNetCore.Authentication.JwtBearer Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/aspnet/AspNetCore) from 3.0.0 to 3.1.18. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Commits](dotnet/aspnetcore@v3.0.0...v3.1.18) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update TestServerExtensionsTests.cs fix test name * Revert updated Microsoft.AspNetCore.Authentication.JwtBearer * ?. removed in last merge * * added tests * Include dependencies.props in "Solution Items" folder Update nugets and sdk version * 42 use GitHub actions instead of appveyor (#45) * Add github workflows * remove appveyor files Co-authored-by: Sergio <[email protected]> * Move "Package information" from "build/dependencies.props" to "Directory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572" * Feature/router paramas with underscores (#51) * allow router params with _ and - * Test for allow router params with _ Co-authored-by: Alexis Martin Peña <[email protected]> * Fix TestServerAction for methods parameters (#43) * Fix TestServerAction for methods parameters * Merge With VFA91 Fork * Add Guid[] In QueryParams * Avoid add parameter when Guid[] is empty * Adding Test * using GuidArrayExtension * Remove unused method * fix for .net5 * Fixing comments * Enable any array from query params * Avoid Array with not primitives types * fix for .net 3.1 * comments fix * Change namespace & Clear function for primitives * remove dynamic * rename variables Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: Sergio <[email protected]> * Set targets and versions to Net Core 3.1, Net 5 and Net 6 Application version 3.2.0 (#54) Set targets and versions to Net Core 3.1, Net 5 and Net 6 Add Directory.Build.targets with version of nugets Modify workflows to support Net 5 and Net 6 Clean ".csproj"s * Feature/update to net6 (#55) Change PackageLicenseUrl to PackageLicenseUrl Remove SetCompatibilityVersion from the code Update README * Feature/nullable query params (#53) * Add Test For try fix a Bug * Allo Query Parameter Nullable * allow .net 3.1 build * add folder again * fix indent * fix indent * indent * indent * fix merge * Change class name and access * Pr Comments * better comment method * comment * improve performance Co-authored-by: Alexis Martin Peña <[email protected]> * Tests using WebApplicationFactory (#58) Documentation about GetStarted, WebApplicationFactory and ICollectionFixture (xunit) Refactor ValuesTests and ValuesWithHttpClientTests to test also WebApplicationFactory Co-authored-by: Sergio <[email protected]> * Allow router params in post methods (#60) Co-authored-by: Alexis Martin Peña <[email protected]> * regex_pattern include several colon (#61) Co-authored-by: Sergio <[email protected]> * Bug filtro isPrimitive y rutas con parametros strings (#64) * * bug en el filtro isPrimitive * * revert cambio para pasarlo a una rama * * Corrección Bug en el filtro isPrimitive * * Corrección bug isPrimitive * Corrección bug endpoint con parametro string en la ruta Co-authored-by: David Jiménez Hernández <[email protected]> * AddQueryParameter extension in RequestBuilder (#65) * feat(RequestBuilder): AddQueryParameter extension in RequestBuilder and their tests * EscapeDataString the name and value * Remove repeated tests * Version 3.3.0 (#66) * Add new sections in the doc: "About adding extra query parameters" and "Improving assertions in API responses" (#68) * Change to central package management (#67) * Change Directory.Build.targets to Directory.Packages.props Minimun sdk version 6.0.300 * REmove PrivateAssets and IncludeAssets from Directory.Packages.props * Update workflows * Remove build\dependencies.props Remove version in Microsoft.SourceLink.GitHub Remove dependencies.props and move the content to Directory.Build.props and Directory.Packages.props Add removed Microsoft.AspNetCore.Mvc.Testing nuget package to Sample.IntegrationTests.csproj * PrivateAssets and IncludeAssets to xunit.runner.visualstudio * tabs to spaces Add PrivateAssets and IncludeAssets to coverlet.collector * Update packages * Refactor Directory.Packages.props to only repeat NetCoreVersion each .Net version Co-authored-by: Vicente Fernández Antolín <[email protected]> Co-authored-by: David Jiménez <[email protected]> Co-authored-by: Carlos Jiménez Delgado <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Jiménez Hernández <[email protected]> Co-authored-by: serweck <[email protected]> Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: David Jiménez Hernández <[email protected]>
AssemblyInfo.cs is not embedded when
EmbedUntrackedSources
is true.The workaround is to specify it manually in
Directory.Build.targets
file. The following also includes workaround for dotnet/msbuild#1479:The text was updated successfully, but these errors were encountered: