Feature/nullable query params #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/router paramas with underscores (Xabaril#51)
added 2 commits
March 21, 2022 13:02
Sergio1192
reviewed
Mar 22, 2022
Fix TestServerAction for methods parameters (Xabaril#43)
serweck
force-pushed
the
feature/nullable-query-params
branch
from
89e6846 to
923e12f
Compare
|
I think now is fine after merge develop |
Sergio1192
reviewed
Mar 28, 2022
Sergio1192
reviewed
Mar 28, 2022
|
Please, add the comments in HttpResponseMessageExtensions/ReadContentAsAsync. I didn't notice before. |
Sergio1192
reviewed
Mar 28, 2022
Sergio1192
reviewed
Mar 28, 2022
src/Acheve.TestHost/Routing/Tokenizers/PrimitiveParameterActionTokenizer.cs
Outdated
Show resolved
Hide resolved
Sergio1192
reviewed
Mar 28, 2022
src/Acheve.TestHost/Routing/Tokenizers/PrimitiveParameterActionTokenizer.cs
Show resolved
Hide resolved
Sergio1192
reviewed
Mar 28, 2022
src/Acheve.TestHost/Routing/Tokenizers/ComplexParameterActionTokenizer.cs
Outdated
Show resolved
Hide resolved
serweck
force-pushed
the
feature/nullable-query-params
branch
from
8dfe99e to
105dc65
Compare
Sergio1192
reviewed
Mar 28, 2022
added 2 commits
March 28, 2022 09:30
Sergio1192
approved these changes
Mar 28, 2022
Sergio1192
added a commit
that referenced
this pull request
Apr 19, 2022
* Include Request with FromHeaderAttribute #32 * * added logic of apicontroller where the [frombody] attribute does not need to be added and fixed bug when i send a object with properties a null in the body * * Update support for method patch * Fix null reference exception when pass null properties in request model * Simplify way of parameter extract * Create a new model in Sample.Api to use it as a parameter Two new endpoints with parameters (custom or primitive object) Tests calling endpoints with a null parameter (custom or primitive object) We check if the instance is null before AddTokken in PrimitiveParameterActionTokenizer and ComplexParameterActionTokenizer We add null argument in TestServerAction instead of a null reference exception * Bump Microsoft.AspNetCore.Authentication.JwtBearer Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/aspnet/AspNetCore) from 3.0.0 to 3.1.18. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Commits](dotnet/aspnetcore@v3.0.0...v3.1.18) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update TestServerExtensionsTests.cs fix test name * Revert updated Microsoft.AspNetCore.Authentication.JwtBearer * ?. removed in last merge * * added tests * Include dependencies.props in "Solution Items" folder Update nugets and sdk version * 42 use GitHub actions instead of appveyor (#45) * Add github workflows * remove appveyor files Co-authored-by: Sergio <[email protected]> * Move "Package information" from "build/dependencies.props" to "Directory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572" * Feature/router paramas with underscores (#51) * allow router params with _ and - * Test for allow router params with _ Co-authored-by: Alexis Martin Peña <[email protected]> * Fix TestServerAction for methods parameters (#43) * Fix TestServerAction for methods parameters * Merge With VFA91 Fork * Add Guid[] In QueryParams * Avoid add parameter when Guid[] is empty * Adding Test * using GuidArrayExtension * Remove unused method * fix for .net5 * Fixing comments * Enable any array from query params * Avoid Array with not primitives types * fix for .net 3.1 * comments fix * Change namespace & Clear function for primitives * remove dynamic * rename variables Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: Sergio <[email protected]> * Set targets and versions to Net Core 3.1, Net 5 and Net 6 Application version 3.2.0 (#54) Set targets and versions to Net Core 3.1, Net 5 and Net 6 Add Directory.Build.targets with version of nugets Modify workflows to support Net 5 and Net 6 Clean ".csproj"s * Feature/update to net6 (#55) Change PackageLicenseUrl to PackageLicenseUrl Remove SetCompatibilityVersion from the code Update README * Feature/nullable query params (#53) * Add Test For try fix a Bug * Allo Query Parameter Nullable * allow .net 3.1 build * add folder again * fix indent * fix indent * indent * indent * fix merge * Change class name and access * Pr Comments * better comment method * comment * improve performance Co-authored-by: Alexis Martin Peña <[email protected]> * Tests using WebApplicationFactory (#58) Documentation about GetStarted, WebApplicationFactory and ICollectionFixture (xunit) Refactor ValuesTests and ValuesWithHttpClientTests to test also WebApplicationFactory Co-authored-by: Sergio <[email protected]> * Allow router params in post methods (#60) Co-authored-by: Alexis Martin Peña <[email protected]> * regex_pattern include several colon (#61) Co-authored-by: Sergio <[email protected]> Co-authored-by: Vicente Fernández Antolín <[email protected]> Co-authored-by: David Jiménez <[email protected]> Co-authored-by: Carlos Jiménez Delgado <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Jiménez Hernández <[email protected]> Co-authored-by: serweck <[email protected]> Co-authored-by: Alexis Martin Peña <[email protected]>
Sergio1192
added a commit
that referenced
this pull request
Jun 7, 2022
* Include Request with FromHeaderAttribute #32 * * added logic of apicontroller where the [frombody] attribute does not need to be added and fixed bug when i send a object with properties a null in the body * * Update support for method patch * Fix null reference exception when pass null properties in request model * Simplify way of parameter extract * Create a new model in Sample.Api to use it as a parameter Two new endpoints with parameters (custom or primitive object) Tests calling endpoints with a null parameter (custom or primitive object) We check if the instance is null before AddTokken in PrimitiveParameterActionTokenizer and ComplexParameterActionTokenizer We add null argument in TestServerAction instead of a null reference exception * Bump Microsoft.AspNetCore.Authentication.JwtBearer Bumps [Microsoft.AspNetCore.Authentication.JwtBearer](https://github.com/aspnet/AspNetCore) from 3.0.0 to 3.1.18. - [Release notes](https://github.com/aspnet/AspNetCore/releases) - [Commits](dotnet/aspnetcore@v3.0.0...v3.1.18) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update TestServerExtensionsTests.cs fix test name * Revert updated Microsoft.AspNetCore.Authentication.JwtBearer * ?. removed in last merge * * added tests * Include dependencies.props in "Solution Items" folder Update nugets and sdk version * 42 use GitHub actions instead of appveyor (#45) * Add github workflows * remove appveyor files Co-authored-by: Sergio <[email protected]> * Move "Package information" from "build/dependencies.props" to "Directory.Build.props" Add Source Link to Github Minimun version 3.1.300 to avoid issue "dotnet/sourcelink#572" * Feature/router paramas with underscores (#51) * allow router params with _ and - * Test for allow router params with _ Co-authored-by: Alexis Martin Peña <[email protected]> * Fix TestServerAction for methods parameters (#43) * Fix TestServerAction for methods parameters * Merge With VFA91 Fork * Add Guid[] In QueryParams * Avoid add parameter when Guid[] is empty * Adding Test * using GuidArrayExtension * Remove unused method * fix for .net5 * Fixing comments * Enable any array from query params * Avoid Array with not primitives types * fix for .net 3.1 * comments fix * Change namespace & Clear function for primitives * remove dynamic * rename variables Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: Sergio <[email protected]> * Set targets and versions to Net Core 3.1, Net 5 and Net 6 Application version 3.2.0 (#54) Set targets and versions to Net Core 3.1, Net 5 and Net 6 Add Directory.Build.targets with version of nugets Modify workflows to support Net 5 and Net 6 Clean ".csproj"s * Feature/update to net6 (#55) Change PackageLicenseUrl to PackageLicenseUrl Remove SetCompatibilityVersion from the code Update README * Feature/nullable query params (#53) * Add Test For try fix a Bug * Allo Query Parameter Nullable * allow .net 3.1 build * add folder again * fix indent * fix indent * indent * indent * fix merge * Change class name and access * Pr Comments * better comment method * comment * improve performance Co-authored-by: Alexis Martin Peña <[email protected]> * Tests using WebApplicationFactory (#58) Documentation about GetStarted, WebApplicationFactory and ICollectionFixture (xunit) Refactor ValuesTests and ValuesWithHttpClientTests to test also WebApplicationFactory Co-authored-by: Sergio <[email protected]> * Allow router params in post methods (#60) Co-authored-by: Alexis Martin Peña <[email protected]> * regex_pattern include several colon (#61) Co-authored-by: Sergio <[email protected]> * Bug filtro isPrimitive y rutas con parametros strings (#64) * * bug en el filtro isPrimitive * * revert cambio para pasarlo a una rama * * Corrección Bug en el filtro isPrimitive * * Corrección bug isPrimitive * Corrección bug endpoint con parametro string en la ruta Co-authored-by: David Jiménez Hernández <[email protected]> * AddQueryParameter extension in RequestBuilder (#65) * feat(RequestBuilder): AddQueryParameter extension in RequestBuilder and their tests * EscapeDataString the name and value * Remove repeated tests * Version 3.3.0 (#66) * Add new sections in the doc: "About adding extra query parameters" and "Improving assertions in API responses" (#68) * Change to central package management (#67) * Change Directory.Build.targets to Directory.Packages.props Minimun sdk version 6.0.300 * REmove PrivateAssets and IncludeAssets from Directory.Packages.props * Update workflows * Remove build\dependencies.props Remove version in Microsoft.SourceLink.GitHub Remove dependencies.props and move the content to Directory.Build.props and Directory.Packages.props Add removed Microsoft.AspNetCore.Mvc.Testing nuget package to Sample.IntegrationTests.csproj * PrivateAssets and IncludeAssets to xunit.runner.visualstudio * tabs to spaces Add PrivateAssets and IncludeAssets to coverlet.collector * Update packages * Refactor Directory.Packages.props to only repeat NetCoreVersion each .Net version Co-authored-by: Vicente Fernández Antolín <[email protected]> Co-authored-by: David Jiménez <[email protected]> Co-authored-by: Carlos Jiménez Delgado <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Jiménez Hernández <[email protected]> Co-authored-by: serweck <[email protected]> Co-authored-by: Alexis Martin Peña <[email protected]> Co-authored-by: David Jiménez Hernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nullable parameters in Query Params
Fix Issues:
#47
#29