Fixing the sourcelink failure for embeded files

[Anipik]

Generating files before sourcelink calculates the embedded files
Fixes #33097

[danmoseley]

Please port to preview 2 branch also. You can consider it approved if risk is acceptable to you and @ericstj

[safern]

cc: @dotnet/runtime-infrastructure

[safern]

Could you also run an official build with this changes and enabling the source link validation?

I think we should enable the source link validation as part of this change to catch these errors earlier.

[Anipik]

Could you also run an official build with this changes and enabling the source link validation?

yeah i will do that.

[Anipik]

https://dev.azure.com/dnceng/internal/_build/results?buildId=557428

official build

[hoyosjs]

That one nit. Also, as long as Mono's SPC build also uses arcade defaults sourcelink should work.

[Anipik]

sourcelink validation succeeded https://dev.azure.com/dnceng/internal/_build/results?buildId=558701

[tmat]

[hoyosjs]

Please port to preview 2 branch also. You can consider it approved if risk is acceptable to you and @ericstj Eric St. John FTE

The prev2 branch wouldn't pass with this change as-is as the arcade version on the branch doesn't contain dotnet/arcade@527179a

[Anipik]

I talked with @ericstj offline. we dont need to port this preview2 as the embedded files dont contain any actual code, these are just typeforwards or attributes. we can wait till preview 3

[Anipik]

@ericstj @safern @ViktorHofer any insight about the failure.
I was not able to find anything good in the log https://helix.dot.net/api/2019-06-17/jobs/3b8f6fb9-6ab6-4ba6-bec5-c9f313c1dc0f/workitems/baseservices.threading/console

This doesnt seem to be related to this pr but i didnt have much info about the error to create an issue for this.

[danmoseley]

@Anipik you might have to try to repro locally? 😕

[safern]

I fixed this here: #33580 you just have to rerun the whole pipeline, or you can ignore and merge.