Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml #3473

Merged
merged 5 commits into from
May 24, 2023

Conversation

ali-turan7
Copy link
Contributor

@ali-turan7 ali-turan7 commented May 23, 2023

Related issue:

#3447

Description

TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml

eng/create-announcement-draft.sh Outdated Show resolved Hide resolved
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the PR accordingly

@ali-turan7 ali-turan7 changed the title Printing the variables inside the callee script. Eliminating the printing of variables that are not inside the scope of the caller May 24, 2023
@ali-turan7 ali-turan7 changed the title Eliminating the printing of variables that are not inside the scope of the caller Removal of the printing of variables that may not inside the scope of the caller. May 24, 2023
@ali-turan7 ali-turan7 changed the title Removal of the printing of variables that may not inside the scope of the caller. TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml May 24, 2023
@ali-turan7 ali-turan7 merged commit b173d41 into main May 24, 2023
@ali-turan7 ali-turan7 deleted the dev/ali-turan/gistTagUrlFix branch May 24, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing untriaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants