Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml #3473

Merged
merged 5 commits into from
May 24, 2023
Merged

TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml #3473

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac775ff
Printing the variables inside the callee script.
ali-turan7 May 23, 2023
72cb36a
commenting out PR for test
ali-turan7 May 23, 2023
5d35668
change Dryrun flag for test
ali-turan7 May 23, 2023
9d86d34
removing the echo lines
ali-turan7 May 24, 2023
12dce15
revert dryrun test mode
ali-turan7 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/create-announcement-draft.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,7 @@ else
export RUNTIME_VERSION_SHORT="$RUNTIME_VERSION"
fi

echo "Tag URL: $TAG_URL"
ali-turan7 marked this conversation as resolved.
Show resolved Hide resolved
echo "Release Notes URL: $RELEASE_NOTES_URL"

envsubst < "$template"
2 changes: 0 additions & 2 deletions eng/templates/stages/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,6 @@ stages:
announcement_url=$( gh api graphql -F RepoId=$(RepoId) -F categoryId=$(DiscussionCategoryId) -F body="$body" -F title="$title" -f query="$query" --template '{{.data.createDiscussion.discussion.url}}' )

echo "Announcement URL: $announcement_url"
echo "Tag URL: $TAG_URL"
echo "Release Notes URL: $RELEASE_NOTES_URL"
fi
displayName: Submit announcement discussion
workingDirectory: $(Agent.BuildDirectory)/dotnet-source-build/eng
Expand Down