Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pipeline: Use of announcement gist results in TAG_URL variable not being set #3447

Closed
Tracked by #3460
mthalman opened this issue May 16, 2023 · 2 comments
Closed
Tracked by #3460
Assignees
Labels
area-release-infra Release infrastructure owned by .NET Product Construction

Comments

@mthalman
Copy link
Member

mthalman commented May 16, 2023

The release pipeline allows you the option of referencing a gist URL that will be used as the content for the release announcement instead of automatically generating it. When that parameter is provided, it results in the following error when executing the Submit announcement discussion task in the release stage:

line 62: TAG_URL: unbound variable

This is because that variable only gets set as a result of running the create-announcement-draft.sh script. But that script doesn't get run when an announcement gist URL is provided.

The same applies for the use of the RELEASE_NOTES_URL variable.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ali-turan7
Copy link
Contributor

TAG_URL and RELEASE_NOTES_URL variables are removed from being printed in release.yml

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-release-infra Release infrastructure owned by .NET Product Construction
Projects
Archived in project
Development

No branches or pull requests

3 participants