Merge master into future #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pilationContext targets. TreatWarningsAsErrors controls warning as error behavior for the entire compilation, while WarningsAsErrors is a string of set of diagnostic IDs that need to be treated as errors. Fixes dotnet#756
…here it's consumed Fixes dotnet#631
… be excluded from publishing Fixes dotnet#376
Partially fixes dotnet#739. The first iteration of cross-targeting support code unconditionally queried each ProjectReference for the best TFM to build against, and then explicitly specified that TFM when building the reference. This caused a race condition when building a set of projects that had a single-TFM project and another project that had a reference to it. The entry point (probably .sln) build would build the referenced project with no TF specified, and then the referencing project would build it with an explicit TF specified. These two builds appeared different to the MSBuild engine (because they had different sets of global properties) and so were both executed, resulting in a race condition. The fix is in two parts: * Allow a project to report back through GetTargetFrameworkProperties that it only has one TF to build. * When a project reports that it has only one TF to build, issue its build request without specifying any TF (dotnet/msbuild#1667) This commit is the former.
Use TreatWarningsAsErrors instead of WarningsAsErrors for PreserveCom…
Update property name for exclude pattern in project folder to match where it's consumed
Giving more information on 'No compatiblity target frameowrk' failure
…ild property page
Add options for appending TFM and RID to the output path. Default the RID option to 'false', since it would be a breaking change at this point. Add extra comments explaining the difference between build and publish outputs in .NET Core projects.
Update the assembly version with every nightly build. Fixes dotnet#488.
Report that a project only has one TFM
Use case insensitive comparison for determining which packages should be excluded from publishing
'dotnet run' doesn't work on self-contained apps
update nuget to rtm-2265
This prevents a conflict with Version being set to 1.0.0.0 by desktop targets before we have a chance to set it to 1.0.0, which was breaking restore. It also breaks VersionPrefix for net4x projects built with desktop msbuild. Also leaving VersionPrefix unset if we do not use it.
Add default values for boolean properties consumed on the advanced build property page
This was benign because imports are already relative to the importing project and the misspelling of MSBuildThisFileDirectory evaluated to empty.
Set version early enough not to be overridden by winfx targets on desktop
Bump CLI to RC4 4771
Our self-contained tests use netcoreapp1.0 and the current machine's RID. When building/running on OSX Sierra this is a problem because netcoreapp1.0 only supported the previous 2 OSX versions. The fix is to check if we are running on a newer OSX machine than what was supported, and downgrade the RID to a supported RID. Fix dotnet#834
Fixing self-contained tests on OSX Sierra
…onFiles task to FrameworkVersion
update nuget to 4.0.0-rtm-2275
…nt with RuntimeFrameworkVersion
Fix typo in .targets header comment
Fix warning in test code
…on-686 Match Microsoft.NETCore.App package version to runtime version, and allow it to float
srivatsn
approved these changes
Feb 10, 2017
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…807.9 (dotnet#857) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19407.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsplaisted @nguerrera @ramarag
/cc @srivatsn