Use case insensitive comparison for determining which packages should be excluded from publishing #809
Conversation
… be excluded from publishing Fixes dotnet#376
| @@ -37,7 +37,7 @@ public IEnumerable<LockFileTargetLibrary> GetRuntimeLibraries(IEnumerable<string | |||
| Dictionary<string, LockFileTargetLibrary> libraryLookup = | |||
| runtimeLibraries.ToDictionary(e => e.Name, StringComparer.OrdinalIgnoreCase); | |||
|
|
|||
| HashSet<string> allExclusionList = new HashSet<string>(); | |||
| HashSet<string> allExclusionList = new HashSet<string>(StringComparer.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
Doing a quick code search, it appears
has the same issue. What do you think about changing that as well? That method is only called from this method and unioned with this hashset, but in case someone else adds a call to it.
There was a problem hiding this comment.
Good catch, thanks. I've made the change you suggest.
|
@dsplaisted can you fill out the template and tag Matt? |
|
Tagging @MattGertz Customer scenario Users who have a PackageReference that's marked as PrivateAssets will have those assets published if the case of the PackageReference doesn't exactly match the NuGet package's name.Bugs this fixes: Fixes Workarounds, if any Fix the casing. Risk Low. Performance impact Low. Is this a regression from a previous update? No. Root cause analysis: Used wrong string comparison. How was the bug found? Customer reported. |
|
JoC approved this offline. |
|
@srivatsn Thanks for filling out the escrow template and getting this merged! |
…728.1 (dotnet#809) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19378.1
Fixes #376