Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreserveCompilationContext targets incorrectly uses WarningsAsErrors #756

Closed
natemcmaster opened this issue Jan 30, 2017 · 1 comment
Closed

PreserveCompilationContext targets incorrectly uses WarningsAsErrors #756

natemcmaster opened this issue Jan 30, 2017 · 1 comment
Assignees
@mavasani
Labels
Bug
Milestone
1.0 RTM

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Jan 30, 2017 •
edited
Loading

dotnet-migrate (since corrected) and PreserveCompilationContext targets use the property WarningsAsErrors. The correct property is TreatWarningsAsErrors. PreserveCompilationContext needs to be updated
@natemcmaster natemcmaster mentioned this issue Jan 30, 2017
Merged
@pranavkm
Copy link
Contributor

Related work item: https://github.com/dotnet/cli/issues/5487

@natemcmaster natemcmaster changed the title WarningsAsErrors or TreatWarningsAsErrors PreserveCompilationContext targets incorrectly uses WarningsAsErrors Jan 31, 2017
@srivatsn srivatsn added the Bug label Jan 31, 2017
@srivatsn srivatsn added this to the 1.0 RTM milestone Jan 31, 2017
mavasani added a commit to mavasani/sdk that referenced this issue Feb 3, 2017
@mavasani
Use TreatWarningsAsErrors instead of WarningsAsErrors for PreserveCom…
240b7be 
…pilationContext targets.

TreatWarningsAsErrors controls warning as error behavior for the entire compilation, while WarningsAsErrors is a string of set of diagnostic IDs that need to be treated as errors.

Fixes dotnet#756
@mavasani mavasani mentioned this issue Feb 3, 2017
Merged
mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@dotnet-maestro @wtgodbe
[release/3.0.1xx] Update dependencies from aspnet/AspNetCore (dotnet#756
091b663 
)

* Update dependencies from https://github.com/aspnet/AspNetCore build 20190703.8

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview7.19353.8
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview7.19353.8

* Manual DARC update to skip batching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Bug
Projects
None yet
Milestone
1.0 RTM
Development

No branches or pull requests
4 participants
@srivatsn @pranavkm @natemcmaster @mavasani