Trim away netframework targets in source-build #83899
Conversation
NikolaMilosavljevic
requested review from
ViktorHofer,
crummel,
MichaelSimons and
mmitche
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details### Summary of the changes This is part of the source-build work to enable trimming of net4* targets. Parent repos ( Here's how this is consumed: dotnet/arcade#12785 Top-level tracking issue: dotnet/source-build#3014 This essentially just avoids building net4* TFMs when building Linux source build. Fixes: #74950
|
|
VERY cool. |
eng/SourceBuild.props
Outdated
| @@ -43,6 +43,8 @@ | |||
| <InnerBuildArgs Condition="'$(ContinuousIntegrationBuild)' != ''">$(InnerBuildArgs) /p:ContinuousIntegrationBuild=$(ContinuousIntegrationBuild)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS)</InnerBuildArgs> | |||
| <InnerBuildArgs Condition="'$(SourceBuildUseMonoRuntime)' == 'true'">$(InnerBuildArgs) /p:PrimaryRuntimeFlavor=Mono /p:RuntimeFlavor=Mono</InnerBuildArgs> | |||
| <!-- Unset NetFrameworkMinimum property, to disable netfx projects. --> | |||
| <InnerBuildArgs>$(InnerBuildArgs) /p:NetFrameworkMinimum=</InnerBuildArgs> | |||
There was a problem hiding this comment.
This should be done in Directory.Build.props instead in order for it work with the -sb switch.
There was a problem hiding this comment.
Thanks - will fix this.
There was a problem hiding this comment.
Fixed with commit: 76779f9
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
Summary of the changes
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likeruntime.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Fixes: #74950