Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test projects fail to restore under /p:DotNetBuildFromSource=true #84617

Closed
tmds opened this issue Apr 11, 2023 · 1 comment · Fixed by #84682
Closed

Some test projects fail to restore under /p:DotNetBuildFromSource=true #84617

tmds opened this issue Apr 11, 2023 · 1 comment · Fixed by #84682

Comments

@tmds
Copy link
Member

tmds commented Apr 11, 2023

In our CI, we build the repo using:

./build.sh /p:DotNetBuildFromSource=true --runtimeconfiguration Release --librariesConfiguration Debug --subset clr+libs+host+packs+libs.tests

Since #83899 (which is clearing NetFrameworkMinimum when DotNetBuildFromSource), a bunch of test projects which have a net48 tfm fail to restore:

System.Management/tests/System.Management.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices/tests/System.DirectoryServices.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices.Protocols/tests/System.DirectoryServices.Protocols.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices.AccountManagement/tests/System.DirectoryServices.AccountManagement.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Runtime.Serialization.Formatters/tests/System.Runtime.Serialization.Formatters.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Runtime.Caching/tests/System.Runtime.Caching.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Net.Http.WinHttpHandler/tests/FunctionalTests/System.Net.Http.WinHttpHandler.Functional.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Net.Http.Json/tests/FunctionalTests/System.Net.Http.Json.Functional.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]

@ViktorHofer @NikolaMilosavljevic how can we fix this?

cc @omajid

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

In our CI, we build the repo using:

./build.sh /p:DotNetBuildFromSource=true --runtimeconfiguration Release --librariesConfiguration Debug --subset clr+libs+host+packs+libs.tests

Since #83899 (which is clearing NetFrameworkMinimum when DotNetBuildFromSource), a bunch of test projects which have a net48 tfm fail to restore:

System.Management/tests/System.Management.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.IO.Packaging/tests/System.IO.Packaging.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices/tests/System.DirectoryServices.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices.Protocols/tests/System.DirectoryServices.Protocols.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.DirectoryServices.AccountManagement/tests/System.DirectoryServices.AccountManagement.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Runtime.Serialization.Formatters/tests/System.Runtime.Serialization.Formatters.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Runtime.Caching/tests/System.Runtime.Caching.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Net.Http.WinHttpHandler/tests/FunctionalTests/System.Net.Http.WinHttpHandler.Functional.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]
System.Net.Http.Json/tests/FunctionalTests/System.Net.Http.Json.Functional.Tests.csproj : error NU1201: Project TestUtilities is not compatible with net48 (.NETFramework,Version=v4.8). Project TestUtilities supports: net8.0 (.NETCoreApp,Version=v8.0) [/home/tester/runtime/Build.proj]

@ViktorHofer @NikolaMilosavljevic how can we fix this?

cc @omajid

Author: tmds
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 12, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Apr 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant