Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better trimming support + trimming fix #12785

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Mar 3, 2023

  • Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards.
  • Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.

To double check:

@mmitche mmitche requested review from NikolaMilosavljevic and a team March 3, 2023 20:37
@mmitche
Copy link
Member Author

mmitche commented Mar 3, 2023

I made some tweaks to this, so I'm retesting locally.

@mmitche
Copy link
Member Author

mmitche commented Mar 3, 2023

One question I had was why Tools.proj looks like this:

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj#L6-L13

I didn't disable trimming in this project yet. I think it might mean that the NuGetRepack pack will not get restored. Anyways, my main question is why this project explicitly sets a bunch of TFM properties.

@NikolaMilosavljevic
Copy link
Member

Just curious, where are these properties consumed? NoTargetFrameworkFiltering and DotNetTargetFrameworkFilter

@mmitche
Copy link
Member Author

mmitche commented Mar 3, 2023

@NikolaMilosavljevic
Copy link
Member

@MichaelSimons

- Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards.
- Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.
@mmitche
Copy link
Member Author

mmitche commented Mar 6, 2023

@NikolaMilosavljevic Slight tweak here to the default TFM string (need re-approval). This did work in source build with it enabled to sdk +installer.

@mmitche mmitche enabled auto-merge (squash) March 6, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants