-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better trimming support + trimming fix #12785
Conversation
I made some tweaks to this, so I'm retesting locally. |
One question I had was why Tools.proj looks like this: I didn't disable trimming in this project yet. I think it might mean that the NuGetRepack pack will not get restored. Anyways, my main question is why this project explicitly sets a bunch of TFM properties. |
Just curious, where are these properties consumed? |
- Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards. - Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.
e5fc7c2
to
3e255bb
Compare
@NikolaMilosavljevic Slight tweak here to the default TFM string (need re-approval). This did work in source build with it enabled to sdk +installer. |
To double check: