Trim away netframework targets in source-build #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Mar 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
==========================================
- Coverage 96.42% 96.42% -0.01%
==========================================
Files 1372 1372
Lines 319881 319881
Branches 10271 10271
==========================================
- Hits 308442 308439 -3
+ Misses 8985 8984 -1
- Partials 2454 2458 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: #6144
Regression? No
Description
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likeroslyn-analyzers.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Tests
Infrastructure change specific for source-build.
Tested in full local source-build.