Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] System.Text.Json tests fail while linking due to OOM #61524

Closed
buyaa-n opened this issue Nov 12, 2021 · 12 comments · Fixed by #67017
Closed

[wasm][aot] System.Text.Json tests fail while linking due to OOM #61524

buyaa-n opened this issue Nov 12, 2021 · 12 comments · Fixed by #67017
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono disabled-test The test is disabled in source code against the issue wasm-aot-test WebAssembly AOT Test
Milestone

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 12, 2021

System.Text.Json.Tests failing in Build Browser wasm Release AllSubsets_Mono_AOT for [release/6.0] branch on this PR

The error log looks similar to this issue:

Linking with emcc. This may take a while ...
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-ld" @/datadisks/disk1/work/BD520A30/t/emscripten_l8no0ble.rsp
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-emscripten-finalize" --minimize-wasm-changes -g --dyncalls-i64 --dwarf /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm --detect-features
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/node/14.15.5_64bit/bin/node" /datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/emscripten/src/compiler.js /datadisks/disk1/work/BD520A30/t/tmpa4attyye.txt
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals
emcc : error : '/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/BD520A30/p/build/wasm/WasmApp.Native.targets(374,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/BD520A30/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]

Same failure in #61491

Runfo Tracking Issue: System.Text.Json.Tests failing in Build Browser wasm Release AllSubsets_Mono_AOT leg

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1681152 runtime PR 67126 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1681152 runtime PR 67126 net7.0-Browser-Release-wasm-Mono_Release-WasmTestOnBrowser-Ubuntu.1804.Amd64.Open console.log runclient.py
1656324 runtime PR 65614 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1655763 runtime PR 66438 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1654725 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1654719 runtime PR 66408 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1654719 runtime PR 66408 net7.0-Browser-Release-wasm-Mono_Release-WasmTestOnBrowser-Ubuntu.1804.Amd64.Open console.log runclient.py
1654324 runtime PR 66373 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1654259 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1653373 runtime PR 65898 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1653029 runtime PR 66373 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1652926 runtime PR 66144 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1652810 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1652772 runtime PR 65537 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1652119 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1651977 runtime PR 66353 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1650022 runtime PR 66315 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1649325 runtime PR 66301 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1649187 runtime PR 66299 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1646435 runtime PR 66230 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1646135 runtime PR 66225 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1644313 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1643540 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1643051 runtime PR 66144 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1641227 runtime PR 66021 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1641169 runtime PR 66106 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1638414 runtime PR 66021 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1636812 runtime PR 65979 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1632648 runtime PR 65898 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1630724 runtime PR 65857 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1630090 runtime PR 65768 net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
1629211 runtime Rolling net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 1 30
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-mono untriaged New issue has not been triaged by the area owner labels Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Text.Json.Tests failing in Build Browser wasm Release AllSubsets_Mono_AOT for [release/6.0] branch on this PR

The error log looks similar to this issue:

Linking with emcc. This may take a while ...
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-ld" @/datadisks/disk1/work/BD520A30/t/emscripten_l8no0ble.rsp
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-emscripten-finalize" --minimize-wasm-changes -g --dyncalls-i64 --dwarf /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm --detect-features
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/node/14.15.5_64bit/bin/node" /datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/emscripten/src/compiler.js /datadisks/disk1/work/BD520A30/t/tmpa4attyye.txt
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals
emcc : error : '/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/BD520A30/p/build/wasm/WasmApp.Native.targets(374,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/BD520A30/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]
Author: buyaa-n
Assignees: -
Labels:

untriaged, area-Infrastructure-mono

Milestone: -

@radical radical added the arch-wasm WebAssembly architecture label Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Text.Json.Tests failing in Build Browser wasm Release AllSubsets_Mono_AOT for [release/6.0] branch on this PR

The error log looks similar to this issue:

Linking with emcc. This may take a while ...
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-ld" @/datadisks/disk1/work/BD520A30/t/emscripten_l8no0ble.rsp
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-emscripten-finalize" --minimize-wasm-changes -g --dyncalls-i64 --dwarf /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm --detect-features
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/node/14.15.5_64bit/bin/node" /datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/emscripten/src/compiler.js /datadisks/disk1/work/BD520A30/t/tmpa4attyye.txt
   "/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals
emcc : error : '/datadisks/disk1/work/BD520A30/p/build/emsdk/upstream/bin/wasm-opt --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/BD520A30/p/build/wasm/WasmApp.Native.targets(374,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/BD520A30/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]

Same failure in #61491

Author: buyaa-n
Assignees: -
Labels:

arch-wasm, untriaged, area-Infrastructure-mono

Milestone: -

@lewing
Copy link
Member

lewing commented Nov 14, 2021

/datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/BD520A30/w/99F6090D/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/BD520A30/p/build/wasm/WasmApp.Native.targets(374,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/BD520A30/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/BD520A30/w/99F6090D/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. 

This is the VM killing the test because it ran out of memory.

cc @steveisok

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 14, 2021
@lewing lewing added this to the 7.0.0 milestone Nov 14, 2021
@lewing
Copy link
Member

lewing commented Nov 14, 2021

cc @ilyas1974

@ericstj ericstj added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 7, 2022
@ericstj
Copy link
Member

ericstj commented Jan 7, 2022

Still happening in release/6.0. https://dev.azure.com/dnceng/public/_build/results?buildId=1541389&view=ms.vss-test-web.build-test-results-tab&runId=43596408&resultId=158013&paneView=debug

  Linking with emcc. This may take a while ...
   "/datadisks/disk1/work/AF620989/p/build/emsdk/upstream/bin/wasm-ld" @/datadisks/disk1/work/AF620989/t/emscripten_u6kd2dfl.rsp
   "/datadisks/disk1/work/AF620989/p/build/emsdk/upstream/bin/wasm-emscripten-finalize" --minimize-wasm-changes -g --dyncalls-i64 --dwarf /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm --detect-features
   "/datadisks/disk1/work/AF620989/p/build/emsdk/node/14.15.5_64bit/bin/node" /datadisks/disk1/work/AF620989/p/build/emsdk/upstream/emscripten/src/compiler.js /datadisks/disk1/work/AF620989/t/tmpjx6y3suh.txt
   "/datadisks/disk1/work/AF620989/p/build/emsdk/upstream/bin/wasm-opt" --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals
emcc : error : '/datadisks/disk1/work/AF620989/p/build/emsdk/upstream/bin/wasm-opt --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/AF620989/w/A26E0953/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/AF620989/p/build/wasm/WasmApp.Native.targets(375,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/AF620989/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/AF620989/w/A26E0953/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. [/datadisks/disk1/work/AF620989/w/A26E0953/e/publish/ProxyProjectForAOTOnHelix.proj]

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-62191-merge-b78860dd399545deaa/System.Text.Json.Tests/1/console.0337f9dc.log?sv=2019-07-07&se=2022-01-27T18%3A59%3A12Z&sr=c&sp=rl&sig=wtlCKkyFcU8KzsGfG7bVdNZqf4yTj7OvdPz3dy5M0e8%3D

@danmoseley
Copy link
Member

danmoseley commented Jan 8, 2022

In my case #63507 (comment) it was a 1 hour timeout. The one above would seem to be as well, although the step only took 45 mins not an hour.

Is it possible to make wasm-opt more verbose (when in CI) so we might get an idea how far it gets ( --debug piped to a file that gets uploaded? ) Or, reduce the optimization level from -Oz so it's faster? (Of course I know nothing of this stuff, just wondering how we can make it actionable..)

@danmoseley
Copy link
Member

Again #63527

@steveisok
Copy link
Member

steveisok commented Jan 8, 2022

@danmoseley I may be butchering the explanation somewhat, but STJ is making LLVM work a bit too hard (generated code size is pretty large) and sometimes we run out of memory. The only two options I know of are 1.) run outside of a docker container and see if the problem goes away or 2.) bump the memory. I had pushed for 2 outright, but we're going to have to make the case by trying 1.

@lewing Correct me if I am wrong, but changing optimization levels I don't think will help all that much.

@radical
Copy link
Member

radical commented Jan 10, 2022

Correct me if I am wrong, but changing optimization levels I don't think will help all that much.

We tried that before, and it was helping for some time but then it started to fail again like this.

@ericstj
Copy link
Member

ericstj commented Jan 11, 2022

This test code may be large, but it's not interconnected. Why would a large but shallow assembly run into memory limits?

To put it another way: I can imagine a fix here is to chunk the one test assembly into a bunch of smaller ones, then I'd ask: why can't LLVM realize it can do something like this when building? Don't we imagine customers running into similar limits? It doesn't feel like a build toolchain should ever OOM as a failure point.

@radical radical changed the title System.Text.Json.Tests failing in Build Browser wasm Release AllSubsets_Mono_AOT leg [wasm][aot] System.Text.Json tests fail while linking due to OOM Feb 15, 2022
radical added a commit to radical/runtime that referenced this issue Feb 16, 2022
- dotnet#65356 - OOM while linking
    `System.Text.Json.SourceGeneration.Roslyn3.11.Tests`

- dotnet#65411 - possible OOM when
  compiling `System.Text.Json.SourceGeneration.Roslyn4.0.Tests.dll.bc` -> `.o`
     `System.Text.Json.SourceGeneration.Roslyn4.0.Tests`

- dotnet#61524 - OOM while linking
    `System.Text.Json.Tests`
@radical radical added disabled-test The test is disabled in source code against the issue wasm-aot-test WebAssembly AOT Test labels Feb 16, 2022
radical added a commit that referenced this issue Feb 17, 2022
* [wasm] Disable aot tests failing due to OOM

- #65356 - OOM while linking
    `System.Text.Json.SourceGeneration.Roslyn3.11.Tests`

- #65411 - possible OOM when
  compiling `System.Text.Json.SourceGeneration.Roslyn4.0.Tests.dll.bc` -> `.o`
     `System.Text.Json.SourceGeneration.Roslyn4.0.Tests`

- #61524 - OOM while linking
    `System.Text.Json.Tests`

* Disable System.Collections.Immutable.Tests due to #65335
@radical
Copy link
Member

radical commented Feb 17, 2022

Disabled the tests in #65413, so removing blocking-clean-ci.

@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 17, 2022
@elinor-fung
Copy link
Member

@radical I'm still seeing System.Text.Json run and fail on the latest rolling build, which has #65413. It looks like that PR only disabled that test and the System.Text.Json.SourceGeneration ones on Windows ('$(BrowserHost)' == 'Windows'), but I think we want to disable it on all platforms?

steveisok pushed a commit to steveisok/runtime that referenced this issue Mar 8, 2022
…configuration

Partial backport of dotnet#65413

dotnet#61524 - OOM while linking `System.Text.Json.Tests`
carlossanlop pushed a commit that referenced this issue Mar 10, 2022
…configuration (#66366)

Partial backport of #65413

#61524 - OOM while linking `System.Text.Json.Tests`

Co-authored-by: Steve Pfister <[email protected]>
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 23, 2022
radical added a commit that referenced this issue Mar 25, 2022
…67017)

Some library tests fail to AOT on helix by getting oomkill'ed. Since the
build machine have more resources than helix, we can AOT these specific
library tests there, and send the built output to helix to run.

Specifically:
- `System.Text.Json.SourceGeneration.Roslyn3.11.Tests`
- `System.Text.Json.SourceGeneration.Roslyn4.0.Tests`
- `System.Text.Json.Tests`
- `Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests` 

This adds two new jobs to `runtime-wasm`, and for rolling builds - `LibraryTests_HighResource_AOT` for linux, and windows.

Fixes #65356 
Fixes #65411
Fixes #61524 
Fixes #66647
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 25, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this issue Mar 30, 2022
…otnet#67017)

Some library tests fail to AOT on helix by getting oomkill'ed. Since the
build machine have more resources than helix, we can AOT these specific
library tests there, and send the built output to helix to run.

Specifically:
- `System.Text.Json.SourceGeneration.Roslyn3.11.Tests`
- `System.Text.Json.SourceGeneration.Roslyn4.0.Tests`
- `System.Text.Json.Tests`
- `Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests` 

This adds two new jobs to `runtime-wasm`, and for rolling builds - `LibraryTests_HighResource_AOT` for linux, and windows.

Fixes dotnet#65356 
Fixes dotnet#65411
Fixes dotnet#61524 
Fixes dotnet#66647
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono disabled-test The test is disabled in source code against the issue wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants