-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Port test-only test fixes #63507
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsPort test only change to fix CallQueryDosDevice. While I was at it, port some other test only fixes as well, some of which I hit locally. Discovered yet another EncryptDecrypt failure mode after messing with my settings - ERROR_ENCRYPTION_DISABLED - and skip on that.
|
Can you link to the change / PR in main that you are porting? I'd like to compare. |
Looks like some build issues. The first one:
|
Curious I didn't get that locally. Hmm.. |
@lewing this one timed out after 1 hour -- seems that "wasm-opt" hung. anything we can collect to diagnose such a thing?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linked issues for all failures. |
Port test only change to fix CallQueryDosDevice. While I was at it, port some other test only fixes as well, some of which I hit locally.
Discovered yet another EncryptDecrypt failure mode after messing with my settings - ERROR_ENCRYPTION_DISABLED - and skip on that.