Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Port test-only test fixes #63507

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

danmoseley
Copy link
Member

Port test only change to fix CallQueryDosDevice. While I was at it, port some other test only fixes as well, some of which I hit locally.

Discovered yet another EncryptDecrypt failure mode after messing with my settings - ERROR_ENCRYPTION_DISABLED - and skip on that.

@danmoseley danmoseley changed the title Port test-only test fixes [release/6.0] Port test-only test fixes Jan 7, 2022
@ghost ghost assigned danmoseley Jan 7, 2022
@ghost
Copy link

ghost commented Jan 7, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Port test only change to fix CallQueryDosDevice. While I was at it, port some other test only fixes as well, some of which I hit locally.

Discovered yet another EncryptDecrypt failure mode after messing with my settings - ERROR_ENCRYPTION_DISABLED - and skip on that.

Author: danmoseley
Assignees: -
Labels:

area-Meta

Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Jan 7, 2022

Can you link to the change / PR in main that you are porting? I'd like to compare.

@danmoseley
Copy link
Member Author

#59760
#63243
part of #62559
part of #58154

@eerhardt
Copy link
Member

eerhardt commented Jan 7, 2022

Looks like some build issues. The first one:

src\libraries\System.IO.FileSystem\tests\File\EncryptDecrypt.Windows.cs(21,36): error CS1069: (NETCORE_ENGINEERING_TELEMETRY=Build) The type name 'ServiceController' could not be found in the namespace 'System.ServiceProcess'. This type has been forwarded to assembly 'System.ServiceProcess.ServiceController, Version=0.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly.

@danmoseley
Copy link
Member Author

Curious I didn't get that locally. Hmm..

@danmoseley
Copy link
Member Author

@lewing this one timed out after 1 hour -- seems that "wasm-opt" hung. anything we can collect to diagnose such a thing?

emcc : error : '/datadisks/disk1/work/ABF5097B/p/build/emsdk/upstream/bin/wasm-opt --post-emscripten --no-exit-runtime -Oz --low-memory-unused --zero-filled-memory --strip-producers /datadisks/disk1/work/ABF5097B/w/B57209DA/e/wasm_build/obj/wasm/for-build/dotnet.wasm -o /datadisks/disk1/work/ABF5097B/w/B57209DA/e/wasm_build/obj/wasm/for-build/dotnet.wasm -g --mvp-features --enable-mutable-globals' failed (received SIGKILL (-9)) [/datadisks/disk1/work/ABF5097B/w/B57209DA/e/publish/ProxyProjectForAOTOnHelix.proj]
/datadisks/disk1/work/ABF5097B/p/build/wasm/WasmApp.Native.targets(375,5): error MSB3073: The command "emcc "@/datadisks/disk1/work/ABF5097B/p/build/microsoft.netcore.app.runtime.browser-wasm/runtimes/browser-wasm/native/src/emcc-default.rsp" "@/datadisks/disk1/work/ABF5097B/w/B57209DA/e/wasm_build/obj/wasm/for-build/emcc-link.rsp"" exited with code 1. [/datadisks/disk1/work/ABF5097B/w/B57209DA/e/publish/ProxyProjectForAOTOnHelix.proj]

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley
Copy link
Member Author

Linked issues for all failures.

@danmoseley danmoseley merged commit dc56b08 into dotnet:release/6.0 Jan 7, 2022
@danmoseley danmoseley deleted the fix.outerloop branch January 7, 2022 23:33
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants