[mono] Cleanup todo items from defines-todo.cmake #66408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used in the runtime anymore.
Not used in the runtime anymore.
We're requiring a recent Android NDK now that only supports unified headers.
It doesn't seem needed anymore. dlsym() on macOS automatically prepends an underscore and from what I can find it was mostly for old *BSDs.
We don't support such an old glibc anymore.
We don't use this and related networking code in the runtime anymore.
We have MONO_ARCH_DISABLE_HW_TRAPS instead.
No longer needed and probably broken due to missing BCL changes.
…E_MOBILE ENABLE_MONODROID was unused and MonoTouch was an earlier name for Xamarin.iOS, replace it with something more descriptive
Not enabled in dotnet/runtime since the beginning. It was also making crashes harder to investigate because we wouldn't get "normal" stack traces that GDB could understand.
We haven't used it and don't plan to.
Xen is not a primary scenario for Mono anymore so we probably don't need this optimization.
akoeplinger
requested review from
vargaz,
lateralusX,
lambdageek,
BrzVlad,
naricc,
SamMonoRT,
thaystg and
marek-safar
as code owners
This was referenced Mar 9, 2022
lambdageek
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Looks ok.
We discussed offline:
- altstack support shoudl stay. We should run a rolling build with it enabled to make sure it doesn't bitrot. /cc @steveisok
- null GC is probably not useful. The motivation for it was for porting, but it's often easier to start with sgen and comment out non-functional parts.
This reverts commit 2ce87ce. We decided to keep it.
We decided we don't need it anymore.
|
I added altstack back and deleted null GC. |
akoeplinger
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are roughly three categories (all in separate commits so it's easier to review):
MAJOR_IN_MKDEVandMAJOR_IN_SYSMACROSNot used in the runtime anymore.
HAVE_EPOLLandHAVE_KQUEUENot used in the runtime anymore.
ANDROID_UNIFIED_HEADERSandHAVE_ANDROID_NDK_VERSION_HWe're requiring a recent Android NDK now that only supports unified headers.
MONO_DL_NEED_USCOREIt doesn't seem needed anymore.
dlsym() on macOS automatically prepends an underscore and from what I can find it was mostly for old *BSDs.
GLIBC_BEFORE_2_3_4_SCHED_SETAFFINITYWe don't support such an old glibc anymore.
HAVE_SIOCGIFCONFWe don't use this and related networking code in the runtime anymore.
DISABLE_HW_TRAPSWe have
MONO_ARCH_DISABLE_HW_TRAPSinstead.MONO_BIG_ARRAYSNo longer needed and probably broken due to missing BCL changes.
ENABLE_MONODROIDand replaceENABLE_MONOTOUCHwithTARGET_APPLE_MOBILEENABLE_MONODROID was unused and MonoTouch was an earlier name for Xamarin.iOS, replace it with something more descriptive
-we decided to keep itHAVE_WORKING_SIGALTSTACKNot enabled in dotnet/runtime since the beginning.
It was also making crashes harder to investigate because we wouldn't get "normal" stack traces that GDB could understand.
MONO_JEMALLOCWe haven't used it and don't plan to.
MONO_XEN_OPTXen is not a primary scenario for Mono anymore so we probably don't need this optimization.
Fix
MONO_KEYWORD_THREADbuild and implementHAVE_TLS_MODEL_ATTRBoehm/Null GC support
MONO_SMALL_CONFIGUSE_MALLOC_FOR_MEMPOOLSENABLE_DTRACEENABLE_EXPERIMENT_TIEREDand remove dynamic experimentsENABLE_OVERRIDABLE_ALLOCATORSMONO_ARCH_ILP32RISCV_FPABI__mono_ppc64__HAVE_ARMV5/6. There is an open question about what we'll do withHAVE_ARMV7, added a TODO comment.