[release/dev17.6] Update dependencies from dotnet/arcade #73864

dotnet-maestro · 2024-06-05T22:33:32Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 803de9f2-7aae-49ed-19a8-08dc852fa6db
Build: 20240520.4
Date Produced: May 20, 2024 11:44:41 PM UTC
Commit: f2b2071632d5d4c46d0f904f2b0d917b1752551b
Branch: refs/heads/release/8.0

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23168.1 to 8.0.0-beta.24270.4
- Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.23168.1 to 8.0.0-beta.24270.4

Updates to .NET SDKs:
- Updates sdk.version to 8.0.100-preview.7.23376.3
- Updates tools.dotnet to 8.0.100-preview.7.23376.3

…520.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.24270.4

src/Compilers/Core/CodeAnalysisTest/Collections/ImmutableSegmentedListBuilderTest.cs

src/Compilers/Core/CodeAnalysisTest/Collections/ImmutableSegmentedListTest.cs

JoeRobich · 2024-06-06T16:50:32Z

src/Workspaces/CoreTestUtilities/Microsoft.CodeAnalysis.Workspaces.Test.Utilities.csproj

@@ -32,7 +32,6 @@
    <PackageReference Include="Nerdbank.Streams" Version="$(NerdbankStreamsVersion)" />
    <PackageReference Include="System.Threading.Tasks.Dataflow" Version="$(SystemThreadingTasksDataflowVersion)" />
    <PackageReference Include="System.Buffers" Version="$(SystemBuffersVersion)" />
-    <PackageReference Include="xunit.assert" Version="$(xunitassertVersion)" />


Backport removing xunit.assert from #68573

JoeRobich · 2024-06-06T16:50:43Z

...est/New.IntegrationTests/Microsoft.VisualStudio.LanguageServices.New.IntegrationTests.csproj

@@ -61,7 +61,6 @@
    <PackageReference Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="$(MicrosoftVisualStudioImagingInterop140DesignTimeVersion)" />
    <PackageReference Include="NuGet.SolutionRestoreManager.Interop" Version="$(NuGetSolutionRestoreManagerInteropVersion)" />
    <PackageReference Include="UIAComWrapper" Version="$(UIAComWrapperVersion)" />
-    <PackageReference Include="xunit.assert" Version="$(xunitassertVersion)" />


Backport removing xunit.assert from #68573

JoeRobich · 2024-06-06T16:51:18Z

src/Workspaces/Core/Portable/Workspace/Solution/Checksum.cs

@@ -119,7 +119,9 @@ public void WriteTo(ObjectWriter writer)
        public void WriteTo(Span<byte> span)
        {
            Contract.ThrowIfFalse(span.Length >= HashSize);
+#pragma warning disable CS9191 // The 'ref' modifier for an argument corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.


Backport pragma disable from #70248

global.json

JoeRobich · 2024-06-06T16:53:09Z

eng/targets/XUnit.targets

@@ -7,7 +7,6 @@
  </PropertyGroup>

  <ItemGroup>
-    <PackageReference Include="xunit.analyzers" Version="$(xunitanalyzersVersion)" IsImplicitlyDefined="true" PrivateAssets="all" />


Backport XUnit.targets change from #68573

…ade in rc1.

global.json

JoeRobich · 2024-06-10T22:26:29Z

/azp run

…se/dev17.6-f1969d28-bf05-4aad-988c-dc5bd3651ad8

The EndToEnd OverflowOnFluentCall test is fixed in #67913, but would be a significant change to backport.

JoeRobich · 2024-06-12T05:00:59Z

src/Compilers/CSharp/Test/Semantic/Semantics/DelegateTypeTests.cs

-<>F{00000001}`2[System.Int32,(fnptr)[]]
-<>A{00000001}`1[(fnptr)[]]
-");
+            CompileAndVerify(comp, expectedOutput: ExecutionConditionUtil.IsCoreClr


Backport test fixes from #68212

JoeRobich · 2024-06-12T05:01:14Z

src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenFunctionPointersTests.cs

@@ -2479,7 +2479,7 @@ static void Main()
        Console.WriteLine(t.ToString());
    }
 }
-", expectedOutput: "System.IntPtr");
+", expectedOutput: ExecutionConditionUtil.IsCoreClr ? "System.Void()" : "System.IntPtr");


Backport test fixes from #68212

JoeRobich · 2024-06-12T05:02:58Z

eng/InternalTools.props

@@ -6,6 +6,10 @@
          https://devdiv.pkgs.visualstudio.com/_packaging/Engineering/nuget/v3/index.json;
          https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;
        </RestoreSources>
+        <RestoreSources>


Backport RestoreSource from #73532

It doesn't look like there's any meaningful change - only whitespace removed. I'm fine with that, but wondering if that is intentional?

EDIT: I guess that's because the target branch changed in #73950.

That's right. We both had the same change but differing whitespace.

JoeRobich · 2024-06-12T05:07:17Z

With Arcade updated we could move the 17.6 official build to 1ES PT which would get us past the current build blockers of unnecessary build parameters and missing variables. (See run)

…5-4aad-988c-dc5bd3651ad8

jjonescz · 2024-06-12T08:20:46Z

eng/InternalTools.props

@@ -6,6 +6,10 @@
          https://devdiv.pkgs.visualstudio.com/_packaging/Engineering/nuget/v3/index.json;
          https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;
        </RestoreSources>
+        <RestoreSources>


It doesn't look like there's any meaningful change - only whitespace removed. I'm fine with that, but wondering if that is intentional?

EDIT: I guess that's because the target branch changed in #73950.

Update dependencies from https://github.com/dotnet/arcade build 20240…

0b97669

…520.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23168.1 -> To Version 8.0.0-beta.24270.4

dotnet-maestro bot requested a review from a team as a code owner June 5, 2024 22:33

dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 5, 2024

Backport test fixes from #70248

1276451

JoeRobich requested a review from a team as a code owner June 5, 2024 23:17

Backport pragma disable from #70248

5e7daff

JoeRobich requested a review from a team as a code owner June 5, 2024 23:22

JoeRobich added 9 commits June 5, 2024 16:47

Pass Refs as ref

e7ebb8a

Backport XUnit.targets change from #68573

7efe8d8

Revert "Pass Refs as ref"

d0fc8b7

Backport removing xunit.assert from #68573

544f07f

Disable a warning.

3333f90

Revert "Disable a warning."

8f8e3d1

Restore newline

995239d

Move to a newer SDK

de68f73

Fix sdk version

119a8d4

JoeRobich reviewed Jun 6, 2024

View reviewed changes

JoeRobich added 3 commits June 6, 2024 10:23

Use a more recent VS

8644b2c

Revert to the SDK used in Arcade and update VS version

91a5a0f

Go back to the .NET 8p7 SDK which predates the ref readonly changes m…

01c7636

…ade in rc1.

build-analysis bot mentioned this pull request Jun 7, 2024

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

3 tasks

sharwell reviewed Jun 7, 2024

View reviewed changes

global.json Outdated Show resolved Hide resolved

JoeRobich added 3 commits June 7, 2024 13:59

Revert "Backport test fixes from #70428"

f435dbb

Require VS 17.6 for build

b9076bb

Backport test fixes from #68212

1c9c747

JoeRobich and others added 3 commits June 10, 2024 15:59

Merge remote-tracking branch 'origin/release/dev17.6' into darc-relea…

a254870

…se/dev17.6-f1969d28-bf05-4aad-988c-dc5bd3651ad8

Skip failing test.

7cdcef3

The EndToEnd OverflowOnFluentCall test is fixed in #67913, but would be a significant change to backport.

Backport RestoreSource from #73532

30c81a5

JoeRobich reviewed Jun 12, 2024

View reviewed changes

JoeRobich requested review from jjonescz and dibarbet June 12, 2024 05:03

Merge branch 'release/dev17.6' into darc-release/dev17.6-f1969d28-bf0…

be2743f

…5-4aad-988c-dc5bd3651ad8

jjonescz approved these changes Jun 12, 2024

View reviewed changes

JoeRobich merged commit e58065d into release/dev17.6 Jun 12, 2024
23 of 28 checks passed

dotnet-maestro bot deleted the darc-release/dev17.6-f1969d28-bf05-4aad-988c-dc5bd3651ad8 branch June 12, 2024 20:12

This was referenced Jun 18, 2024

[Automated] PRs inserted in VS build main-35017.309 #74045

Closed

[Automated] PRs inserted in VS build feature.debugger.main-35020.110 #74093

Closed

dotnet-bot mentioned this pull request Jun 27, 2024

[Automated] PRs inserted in VS build feature.dotnetVS-35026.97 #74176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/dev17.6] Update dependencies from dotnet/arcade #73864

[release/dev17.6] Update dependencies from dotnet/arcade #73864

dotnet-maestro bot commented Jun 5, 2024 •

edited by JoeRobich

Loading

JoeRobich Jun 6, 2024

JoeRobich Jun 6, 2024

JoeRobich Jun 6, 2024

JoeRobich Jun 6, 2024

JoeRobich commented Jun 10, 2024

JoeRobich Jun 12, 2024

JoeRobich Jun 12, 2024

JoeRobich Jun 12, 2024

jjonescz Jun 12, 2024 •

edited

Loading

JoeRobich Jun 12, 2024

JoeRobich commented Jun 12, 2024 •

edited

Loading

jjonescz Jun 12, 2024 •

edited

Loading

[release/dev17.6] Update dependencies from dotnet/arcade #73864

[release/dev17.6] Update dependencies from dotnet/arcade #73864

Conversation

dotnet-maestro bot commented Jun 5, 2024 • edited by JoeRobich Loading

From https://github.com/dotnet/arcade

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeRobich commented Jun 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjonescz Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeRobich commented Jun 12, 2024 • edited Loading

jjonescz Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

dotnet-maestro bot commented Jun 5, 2024 •

edited by JoeRobich

Loading

jjonescz Jun 12, 2024 •

edited

Loading

JoeRobich commented Jun 12, 2024 •

edited

Loading

jjonescz Jun 12, 2024 •

edited

Loading