Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #68573

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 13, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23218.1 to 1.0.0-beta.23312.2 (parent: Microsoft.DotNet.Arcade.Sdk)
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23218.3 to 8.0.0-beta.23309.3 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: 7e4fe80a-482b-4a41-5b66-08d8d8feb47e
  • Build: 20230614.1
  • Date Produced: June 14, 2023 5:18:10 PM UTC
  • Commit: c27937680063bcf06804c9fd0466d26a0f9ea4e6
  • Branch: refs/heads/main

…609.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23220.2 -> To Version 8.0.0-beta.23309.8

Dependency coherency updates

Microsoft.DotNet.XliffTasks,Microsoft.SourceLink.GitHub
 From Version 1.0.0-beta.23165.1 -> To Version 1.0.0-beta.23305.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner June 13, 2023 12:06
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 13, 2023
ghost
ghost previously requested changes Jun 13, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure-current-swat before merging.
Tasks:

  • Getting Started Documentation has been updated
  • NuGet dependency version updated to match version shipping in SDK

dotnet-maestro bot and others added 3 commits June 14, 2023 12:10
…613.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23220.2 -> To Version 8.0.0-beta.23313.6

Dependency coherency updates

Microsoft.DotNet.XliffTasks,Microsoft.SourceLink.GitHub
 From Version 1.0.0-beta.23218.1 -> To Version 1.0.0-beta.23312.2 (parent: Microsoft.DotNet.Arcade.Sdk
@dibarbet dibarbet requested review from a team as code owners June 14, 2023 18:42
@RikkiGibson
Copy link
Contributor

It looks like removing the xunit reference breaks some build configurations. Do we need some condition in the PackageReference to sort this out?

@dibarbet dibarbet force-pushed the darc-main-cf8f6d0b-3a6d-407a-a47c-6f35afed7dfc branch from b26f208 to 9daf339 Compare June 14, 2023 19:54
@dibarbet dibarbet force-pushed the darc-main-cf8f6d0b-3a6d-407a-a47c-6f35afed7dfc branch from 9daf339 to 1648f51 Compare June 14, 2023 20:31
@dibarbet
Copy link
Member

It looks like removing the xunit reference breaks some build configurations. Do we need some condition in the PackageReference to sort this out?

Updated this - I removed too many references by accident

dotnet-maestro bot and others added 2 commits June 15, 2023 12:09
…614.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23220.2 -> To Version 8.0.0-beta.23314.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks,Microsoft.SourceLink.GitHub
 From Version 1.0.0-beta.23218.1 -> To Version 1.0.0-beta.23312.2 (parent: Microsoft.DotNet.Arcade.Sdk
@jjonescz jjonescz dismissed ghost ’s stale review June 15, 2023 15:47

tasks completed

@dibarbet
Copy link
Member

@jjonescz FYI - @RikkiGibson fixed the warnings in this PR - #68627 . Since that one is already merged I'll revert your commit here and merge in main to pickup Rikki's, since we shouldn't need both.

@dibarbet
Copy link
Member

Ooops - looks like Rikki's change wasn't enough. I'll re-add your change back in. My bad!

@dotnet-maestro dotnet-maestro bot merged commit 1a29604 into main Jun 15, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-cf8f6d0b-3a6d-407a-a47c-6f35afed7dfc branch June 15, 2023 19:11
@ghost ghost added this to the Next milestone Jun 15, 2023
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jan's changes LGTM

@RikkiGibson RikkiGibson removed this from the Next milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants