[main] Update dependencies from dotnet/arcade #70248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…004.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
previously requested changes
Oct 5, 2023
Cannot be fixed easily since it depends on the target framework.
jjonescz
dismissed
ghost
’s stale review
Tasks skipped (major SDK version didn't change; MicrosoftNetCompilersToolsetVersion already matches)
jjonescz
force-pushed
the
darc-main-ba471fc7-7b6c-4e9f-b6df-e69ae29dc370
branch
from
f3cb77d to
1e4237c
Compare
cston
reviewed
Oct 5, 2023
| @@ -133,7 +133,9 @@ public void WriteTo(ObjectWriter writer) | |||
| public void WriteTo(Span<byte> span) | |||
| { | |||
| Contract.ThrowIfFalse(span.Length >= HashSize); | |||
| #pragma warning disable CS9191 // The 'ref' modifier for an argument corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead. | |||
| Contract.ThrowIfFalse(MemoryMarshal.TryWrite(span, ref Unsafe.AsRef(in this))); | |||
There was a problem hiding this comment.
Because MemoryMarshal.TryWrite has still ref parameter on older TFMs (before net8.0) and that cannot take in argument.
ghost
added this to the 
dotnet-maestro
bot
deleted the
darc-main-ba471fc7-7b6c-4e9f-b6df-e69ae29dc370
branch
JoeRobich
added a commit
that referenced
this pull request
Jun 5, 2024
JoeRobich
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/arcade