Ensure diagnostic logger verbosity Fixes #7780 #7897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7780
Context
When using MSBuildDebugEngine, we should log everything at diagnostic verbosity. If no loggers were attached in the normal way, we still set verbosity to diagnostic (for command line builds) and manually set both DetailedSummary and LogTaskInputs on the BuildParameters in BuildManager. I believe these are the only two variables set by binlogs that weren't being set by MSBuildDebugEngine.
Changes Made
This sets the verbosity to diagnostic in XMake and sets DetailedSummary and LogTaskInputs on BuildParameters.
Testing
Notes