Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure diagnostic logger verbosity Fixes #7780 #7897

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Ensure diagnostic logger verbosity Fixes #7780 #7897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0316744
Ensure diagnostic logger verbosity
Forgind Aug 18, 2022
4b4fcda
Add comment
Forgind Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Build/BackEnd/BuildManager/BuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,12 @@ public void BeginBuild(BuildParameters parameters)

_previousLowPriority = parameters.LowPriority;

if (Traits.Instance.DebugEngine)
{
parameters.DetailedSummary = true;
parameters.LogTaskInputs = true;
Comment on lines +471 to +472
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What other implications does setting summary here have? Does it affect attached loggers?

}

lock (_syncLock)
{
AttachDebugger();
Expand Down
6 changes: 6 additions & 0 deletions src/MSBuild/XMake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2366,6 +2366,12 @@ string commandLine
out enableProfiler
);

// We're finished with defining individual loggers' verbosity at this point, so we don't need to worry about messing them up.
if (Traits.Instance.DebugEngine)
{
verbosity = LoggerVerbosity.Diagnostic;
rainersigwald marked this conversation as resolved.
Show resolved Hide resolved
}

if (commandLineSwitches.IsParameterizedSwitchSet(CommandLineSwitches.ParameterizedSwitch.DetailedSummary))
{
detailedSummary = ProcessBooleanSwitch(commandLineSwitches[CommandLineSwitches.ParameterizedSwitch.DetailedSummary], defaultValue: true, resourceName: "InvalidDetailedSummaryValue");
Expand Down